Re: [PATCH v18 6/6] ARM: socfpga: fpga bridge driver support

From	Moritz Fischer <moritz.fischer@ettus.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v18 6/6] ARM: socfpga: fpga bridge driver support
Date	2016-08-08 23:20 +0200
Message-ID	<s407M-6FT-25@gated-at.bofh.it> (permalink)
References	<rUVK2-5Zr-19@gated-at.bofh.it> <rUVK2-5Zr-21@gated-at.bofh.it> <rUVK2-5Zr-17@gated-at.bofh.it> <s407M-6FT-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Alan,

On Mon, Aug 8, 2016 at 12:18 PM, atull <atull@opensource.altera.com> wrote:

>> Please don't use module.h in drivers controlled by a bool
>> Kconfig setting.
>>
>> THanks,
>> Paul.
>>
>
> Thanks for the feedback.  Can you provide an example of what you
> would consider to be proper usage in the kernel?


I think Paul is suggesting to use

static int __init alt_fpga_bridge_init(void)
{
        platform_driver_register(&alt_fpga_bridge_driver);
}

device_initcall(alt_fpga_bridge_init);

or better:

builtin_platform_driver(&alt_fpga_bridge_driver);

Like for example in: drivers/cpuidle/cpuidle-mvebu-v7.c

Cheers,

Moritz

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v18 6/6] ARM: socfpga: fpga bridge driver support Moritz Fischer <moritz.fischer@ettus.com> - 2016-08-08 23:20 +0200
  Re: [PATCH v18 6/6] ARM: socfpga: fpga bridge driver support Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-08-09 18:10 +0200

csiph-web