Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1457471

Re: [PATCH] scripts/Lindent: clean up and optimize

From Jean Delvare <jdelvare@suse.de>
Newsgroups linux.kernel
Subject Re: [PATCH] scripts/Lindent: clean up and optimize
Date 2016-08-07 17:50 +0200
Message-ID <s3yuR-5FQ-3@gated-at.bofh.it> (permalink)
References <s2JC2-5By-5@gated-at.bofh.it> <s2Rzz-2eU-3@gated-at.bofh.it>
Organization SUSE Linux

Show all headers | View raw


Hi Joe,

On Fri, 05 Aug 2016 10:53:19 -0700, Joe Perches wrote:
> On Fri, 2016-08-05 at 11:26 +0200, Jean Delvare wrote:
> > * Add a few blank lines to improve readability.
> > * Don't call cut 3 times when once is enough.
> > * Drop a useless semicolon.
> 
> As it commonly reflows > 80 column code very badly,
> my preference would be to remove Lindent instead.
> 
> https://lkml.org/lkml/2013/2/11/390

This was 3.5 years ago, so apparently it's not happening.

Why don't you just remove -l80 from the options, if this is your only
concern with the script? Adding the appropriate option to indent to
support what we think is good would seem even better, but I do not have
any time to devote to this task.

-- 
Jean Delvare
SUSE L3 Support

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] scripts/Lindent: clean up and optimize Jean Delvare <jdelvare@suse.de> - 2016-08-05 11:30 +0200
  Re: [PATCH] scripts/Lindent: clean up and optimize Joe Perches <joe@perches.com> - 2016-08-05 20:00 +0200
    Re: [PATCH] scripts/Lindent: clean up and optimize Jean Delvare <jdelvare@suse.de> - 2016-08-07 17:50 +0200
      Re: [PATCH] scripts/Lindent: clean up and optimize Joe Perches <joe@perches.com> - 2016-08-07 18:20 +0200

csiph-web