Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1457450

Re: [PATCH 2/2] mm: compaction.c: Add/Modify direct compaction tracepoints

Show all headers | View raw

> On Aug 1, 2016, at 6:55 PM, Vlastimil Babka <vbabka@suse.cz> wrote:
> 
> 
> Yea, this tracepoint has been odd in not printing node/zone in a friendly way (it's possible to determine it from zone_start/zone_end though, so this is good in general. But instead of printing nid and zid like this, it would be nice to unify the output with the other tracepoints, e.g.:
> 
> DECLARE_EVENT_CLASS(mm_compaction_suitable_template,
> [...]
>        TP_printk("node=%d zone=%-8s order=%d ret=%s",
>                __entry->nid,
>                __print_symbolic(__entry->idx, ZONE_TYPE),

Sure, I’ll do that in v2. Thanks!

Also, I guess I should have mentioned that the tracepoint added
at the end of the compaction code wasn’t just for deriving latency information. 
rc and *contended would give us the result of the compaction attempted, 
which I thought would be useful.

I get that begin/end tracepoints aren’t required here, but how about having
trace_mm_compaction_try_to_compact_pages moved to the end to 
include compaction status?

Janani.
> 
> Thanks,
> Vlastimil

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] New tracepoints for slowpath and memory compaction Janani Ravichandran <janani.rvchndrn@gmail.com> - 2016-07-27 16:50 +0200
  [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath Janani Ravichandran <janani.rvchndrn@gmail.com> - 2016-07-27 16:50 +0200
    Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath Steven Rostedt <rostedt@goodmis.org> - 2016-07-27 17:30 +0200
      Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath Dave Hansen <dave.hansen@intel.com> - 2016-07-27 19:30 +0200
        Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath Steven Rostedt <rostedt@goodmis.org> - 2016-07-27 19:40 +0200
      Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath Janani Ravichandran <janani.rvchndrn@gmail.com> - 2016-07-28 22:20 +0200
        Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath Steven Rostedt <rostedt@goodmis.org> - 2016-08-04 17:30 +0200
          Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath Janani Ravichandran <janani.rvchndrn@gmail.com> - 2016-08-05 18:20 +0200
            Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath Steven Rostedt <rostedt@goodmis.org> - 2016-08-05 18:40 +0200
              Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath Janani Ravichandran <janani.rvchndrn@gmail.com> - 2016-08-07 12:40 +0200
    Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath Michal Hocko <mhocko@kernel.org> - 2016-07-27 18:40 +0200
      Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath Rik van Riel <riel@surriel.com> - 2016-07-27 20:20 +0200
        Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath Steven Rostedt <rostedt@goodmis.org> - 2016-07-27 20:30 +0200
        Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath Michal Hocko <mhocko@kernel.org> - 2016-07-27 20:50 +0200
          Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath Rik van Riel <riel@surriel.com> - 2016-07-27 21:00 +0200
  [PATCH 2/2] mm: compaction.c: Add/Modify direct compaction  tracepoints Janani Ravichandran <janani.rvchndrn@gmail.com> - 2016-07-27 17:00 +0200
    Re: [PATCH 2/2] mm: compaction.c: Add/Modify direct compaction  tracepoints Steven Rostedt <rostedt@goodmis.org> - 2016-07-27 17:30 +0200
    Re: [PATCH 2/2] mm: compaction.c: Add/Modify direct compaction  tracepoints Vlastimil Babka <vbabka@suse.cz> - 2016-08-01 15:30 +0200
      Re: [PATCH 2/2] mm: compaction.c: Add/Modify direct compaction tracepoints Janani Ravichandran <janani.rvchndrn@gmail.com> - 2016-08-07 14:40 +0200

csiph-web