Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1457440

Re: [PATCH] proc: much faster /proc/vmstat

Show all headers | View raw

On Sun, Aug 07, 2016 at 02:35:13AM +0100, Al Viro wrote:
> On Sat, Aug 06, 2016 at 03:54:56PM +0300, Alexey Dobriyan wrote:
> 
> [sprintf sucks, let's convert numbers manually]
> 
> > --- a/mm/vmstat.c
> > +++ b/mm/vmstat.c
> > @@ -1592,7 +1592,10 @@ static int vmstat_show(struct seq_file *m, void *arg)
> >  {
> >  	unsigned long *l = arg;
> >  	unsigned long off = l - (unsigned long *)m->private;
> > -	seq_printf(m, "%s %lu\n", vmstat_text[off], *l);
> > +
> > +	seq_puts(m, vmstat_text[off]);
> > +	seq_put_decimal_ull(m, ' ', *l);
> > +	seq_putc(m, '\n');
> >  	return 0;
> >  }
> 
> If that manages to be a hotspot, we really should
> 	* educate the wankers responsible for the userland code in question,
> until they repent and cease committing such abominations.

I'll get right on that.

> 	* look into fixing vsnprintf().  
> 
> Seriously, what the hell is vsnprintf() doing that takes so much time?  It's
> not as if it was a complex format anyway.  WTF is going on there?  Where is
> it spending that much time?

1. format_decode() is busy looking for format specifier: 2 branches per character
   (not in this case, but in others)

2. approximately million branches while parsing format mini language
   and everywhere

3. just look at what string() does
   /proc/vmstat is good case because most of its content are strings

But the patch will still be faster.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] proc: much faster /proc/vmstat Alexey Dobriyan <adobriyan@gmail.com> - 2016-08-07 00:30 +0200
  Re: [PATCH] proc: much faster /proc/vmstat Al Viro <viro@ZenIV.linux.org.uk> - 2016-08-07 03:40 +0200
    Re: [PATCH] proc: much faster /proc/vmstat Alexey Dobriyan <adobriyan@gmail.com> - 2016-08-07 10:50 +0200

csiph-web