Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1457433

Re: [PATCH] drm: Don't prepare or cleanup unchanging frame buffers [v2]

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Daniel Vetter <daniel@ffwll.ch> writes:

> Hm, I can't see v1 anywhere, but I think it'd be better. You can't store
> any transient state related to the current update in struct drm_plane. In
> this case the cleanup_buffers from a previous update might overlap (for
> nonblocking atomic commits) with the prepare_planes for the next one.
> Either we need special cleanup vs. error-path code, or some flag somewhere
> in the drm_plane_state.

Ok, here's pretty much the previous version, which works now that I've
fixed the intel driver. Instead of just comparing the fb's, I'm using
the framebuffer_changed function, which seems like a nice bit of
documentation if nothing else.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm: Don't prepare or cleanup unchanging frame buffers [v2] Keith Packard <keithp@keithp.com> - 2016-07-31 10:10 +0200
  Re: [PATCH] drm: Don't prepare or cleanup unchanging frame buffers  [v2] kbuild test robot <lkp@intel.com> - 2016-07-31 11:30 +0200
  Re: [PATCH] drm: Don't prepare or cleanup unchanging frame buffers  [v2] Daniel Vetter <daniel@ffwll.ch> - 2016-08-02 16:10 +0200
    Re: [PATCH] drm: Don't prepare or cleanup unchanging frame buffers [v2] Keith Packard <keithp@keithp.com> - 2016-08-07 07:30 +0200
      Re: [PATCH] drm: Don't prepare or cleanup unchanging frame buffers  [v2] Daniel Vetter <daniel@ffwll.ch> - 2016-08-08 11:10 +0200
        Re: [PATCH] drm: Don't prepare or cleanup unchanging frame buffers [v2] Keith Packard <keithp@keithp.com> - 2016-08-08 17:20 +0200

csiph-web