[PATCH v2 05/14] net: ethernet: ti: cpsw: don't check slave num in runtime

From	Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Newsgroups	linux.kernel
Subject	[PATCH v2 05/14] net: ethernet: ti: cpsw: don't check slave num in runtime
Date	2016-08-06 22:20 +0200
Message-ID	<s3geC-22d-15@gated-at.bofh.it> (permalink)
References	<s3g4W-1Yq-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

No need to check const slave num in runtime for every packet,
and ndev for slaves w/o ndev is anyway NULL. So remove redundant
check.

Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
 drivers/net/ethernet/ti/cpsw.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index 70a9570..19aa4bb 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -498,8 +498,7 @@ static const struct cpsw_stats cpsw_gstrings_stats[] = {
 				(func)(slave++, ##arg);			\
 	} while (0)
 #define cpsw_get_slave_ndev(priv, __slave_no__)				\
-	((__slave_no__ < priv->data.slaves) ?				\
-		priv->slaves[__slave_no__].ndev : NULL)
+		priv->slaves[__slave_no__].ndev
 #define cpsw_get_slave_priv(priv, __slave_no__)				\
 	(((__slave_no__ < priv->data.slaves) &&				\
 		(priv->slaves[__slave_no__].ndev)) ?			\
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 05/14] net: ethernet: ti: cpsw: don't check slave num in runtime Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> - 2016-08-06 22:20 +0200
  Re: [PATCH v2 05/14] net: ethernet: ti: cpsw: don't check slave num  in runtime Grygorii Strashko <grygorii.strashko@ti.com> - 2016-08-09 13:40 +0200
    Re: [PATCH v2 05/14] net: ethernet: ti: cpsw: don't check slave num  in runtime Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> - 2016-08-09 14:10 +0200

csiph-web