[PATCH v4 05/10] usb: gadget: f_midi: defaults buflen sizes to 512

From	"Felipe F. Tonello" <eu@felipetonello.com>
Newsgroups	linux.kernel
Subject	[PATCH v4 05/10] usb: gadget: f_midi: defaults buflen sizes to 512
Date	2016-08-08 22:40 +0200
Message-ID	<s3Zv4-6cB-33@gated-at.bofh.it> (permalink)
References	<s3Zv3-6cB-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

512 is the value used by wMaxPacketSize, as specified by the USB Spec. This
makes sure this driver uses, by default, the most optimal value for IN and OUT
endpoint requests.

Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
 drivers/usb/gadget/function/f_midi.c | 2 +-
 drivers/usb/gadget/legacy/gmidi.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
index 39018dea7035..a7b50ac947f8 100644
--- a/drivers/usb/gadget/function/f_midi.c
+++ b/drivers/usb/gadget/function/f_midi.c
@@ -1122,7 +1122,7 @@ static struct usb_function_instance *f_midi_alloc_inst(void)
 	opts->func_inst.free_func_inst = f_midi_free_inst;
 	opts->index = SNDRV_DEFAULT_IDX1;
 	opts->id = SNDRV_DEFAULT_STR1;
-	opts->buflen = 256;
+	opts->buflen = 512;
 	opts->qlen = 32;
 	opts->in_ports = 1;
 	opts->out_ports = 1;
diff --git a/drivers/usb/gadget/legacy/gmidi.c b/drivers/usb/gadget/legacy/gmidi.c
index fc2ac150f5ff..0bf39c3ccdb1 100644
--- a/drivers/usb/gadget/legacy/gmidi.c
+++ b/drivers/usb/gadget/legacy/gmidi.c
@@ -47,7 +47,7 @@ static char *id = SNDRV_DEFAULT_STR1;
 module_param(id, charp, S_IRUGO);
 MODULE_PARM_DESC(id, "ID string for the USB MIDI Gadget adapter.");
 
-static unsigned int buflen = 256;
+static unsigned int buflen = 512;
 module_param(buflen, uint, S_IRUGO);
 MODULE_PARM_DESC(buflen, "MIDI buffer length");
 
-- 
2.9.2

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 00/10] Gadget endpoint request allocation and MIDI "Felipe F. Tonello" <eu@felipetonello.com> - 2016-08-08 22:40 +0200
  [PATCH v4 04/10] usb: gadget: f_midi: remove alignment code for OUT endpoint "Felipe F. Tonello" <eu@felipetonello.com> - 2016-08-08 22:40 +0200
  [PATCH v4 03/10] usb: gadget: align buffer size when allocating for OUT endpoint "Felipe F. Tonello" <eu@felipetonello.com> - 2016-08-08 22:40 +0200
  [PATCH v4 02/10] usb: gadget: change len to size_t on alloc_ep_req() "Felipe F. Tonello" <eu@felipetonello.com> - 2016-08-08 22:40 +0200
  [PATCH v4 06/10] usb: gadget: f_midi: refactor state machine "Felipe F. Tonello" <eu@felipetonello.com> - 2016-08-08 22:40 +0200
  [PATCH v4 09/10] usb: gadget: f_hid: use free_ep_req() "Felipe F. Tonello" <eu@felipetonello.com> - 2016-08-08 22:40 +0200
  [PATCH v4 10/10] usb: gadget: f_hid: use alloc_ep_req() "Felipe F. Tonello" <eu@felipetonello.com> - 2016-08-08 22:40 +0200
  [PATCH v4 05/10] usb: gadget: f_midi: defaults buflen sizes to 512 "Felipe F. Tonello" <eu@felipetonello.com> - 2016-08-08 22:40 +0200

csiph-web