Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1457918
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] exynos-drm: Fix unsupported GEM memory type error message to be clear |
| Date | 2016-08-08 19:00 +0200 |
| Message-ID | <s3W4f-3QC-29@gated-at.bofh.it> (permalink) |
| References | <s3jvP-48q-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Aug 05, 2016 at 07:50:06PM -0600, Shuah Khan wrote:
> Fix unsupported GEM memory type error message to include the memory type
> information.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_fb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c
> index e016640..c9315df 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c
> @@ -55,11 +55,11 @@ static int check_fb_gem_memory_type(struct drm_device *drm_dev,
> flags = exynos_gem->flags;
>
> /*
> - * without iommu support, not support physically non-continuous memory
> + * without iommu support, not support physically non-contiguous memory
While at it, how about changing entire sentence to something in English? :)
Best regards,
Krzysztof
> * for framebuffer.
> */
> if (IS_NONCONTIG_BUFFER(flags)) {
> - DRM_ERROR("cannot use this gem memory type for fb.\n");
> + DRM_ERROR("Non-continguous GEM memory is not supported.\n");
> return -EINVAL;
> }
>
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] exynos-drm: Fix unsupported GEM memory type error message to be clear Shuah Khan <shuahkh@osg.samsung.com> - 2016-08-07 01:50 +0200
Re: [PATCH] exynos-drm: Fix unsupported GEM memory type error message to be clear Krzysztof Kozlowski <krzk@kernel.org> - 2016-08-08 19:00 +0200
Re: [PATCH] exynos-drm: Fix unsupported GEM memory type error message to be clear Shuah Khan <shuahkh@osg.samsung.com> - 2016-08-08 23:40 +0200
csiph-web