Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

From	Robert Foss <robert.foss@collabora.com>
Newsgroups	linux.kernel
Subject	Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error
Date	2016-08-08 16:40 +0200
Message-ID	<s3TSF-2yD-21@gated-at.bofh.it> (permalink)
References	(3 earlier) <s1Iyn-5ut-79@gated-at.bofh.it> <s1J1p-5FG-75@gated-at.bofh.it> <s21Um-1q9-21@gated-at.bofh.it> <s2uWm-49j-15@gated-at.bofh.it> <s3sfM-1Mt-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 2016-08-07 04:59 AM, Oliver Neukum wrote:
> On Thu, 2016-08-04 at 13:44 -0400, Robert Foss wrote:
>>
>> On 2016-08-03 06:39 AM, Oliver Neukum wrote:
>>> On Tue, 2016-08-02 at 10:37 -0400, Robert Foss wrote:
>
>>> How can that depend on what we return to user space?
>>> In the driver we can continue just ignoring errors.
>>> Now, if user space stops reading because we reported an error,
>>> that is the decision user space has made. We cannot ignore errors
>>> in the kernel because we don't like what user space does when it
>>> sees the error.
>>
>> So perhaps the better solution is to be more intelligent about how
>> desc->rerr is written to during after an error to be able to maintain
>> the error condition?
>
> Yes, good idea. I think an error condition should never be overwritten.
> So we go to the current behaviour only if a second error before
> user space has seen the3 first error arises. Would that fix your
> issue?

Excellent!

As long as the device is able to keep pushing data during an -EPIPE 
error condition, I think my issues would be solved.

Thread

[PACTH v1] cdc-wdm: Clear read pipeline in case of error robert.foss@collabora.com - 2016-07-28 20:30 +0200
  Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error Robert Foss <robert.foss@collabora.com> - 2016-08-02 16:10 +0200
    Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error Oliver Neukum <oneukum@suse.com> - 2016-08-02 16:10 +0200
      Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error Robert Foss <robert.foss@collabora.com> - 2016-08-02 16:40 +0200
        Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error Oliver Neukum <oneukum@suse.com> - 2016-08-03 12:50 +0200
          Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error Robert Foss <robert.foss@collabora.com> - 2016-08-04 19:50 +0200
            Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error Oliver Neukum <oneukum@suse.com> - 2016-08-07 11:10 +0200
              Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error Robert Foss <robert.foss@collabora.com> - 2016-08-08 16:40 +0200
  Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error Oliver Neukum <oneukum@suse.com> - 2016-08-02 16:50 +0200

csiph-web