Re: [PATCH] [net] rxrpc: fix uninitialized pointer dereference in debug code

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] [net] rxrpc: fix uninitialized pointer dereference in debug code
Date	2016-08-08 14:50 +0200
Message-ID	<s3Sad-1rV-3@gated-at.bofh.it> (permalink)
References	<s3PP4-8vc-15@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Arnd Bergmann <arnd@arndb.de> wrote:

> A newly added bugfix caused an uninitialized variable to be
> used for printing debug output. This is harmless as long
> as the debug setting is disabled, but otherwise leads to an
> immediate crash.
> 
> gcc warns about this when -Wmaybe-uninitialized is enabled:
> 
> net/rxrpc/call_object.c: In function 'rxrpc_release_call':
> net/rxrpc/call_object.c:496:163: error: 'sp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> The initialization was removed but one of the users remains.
> This adds back the initialization.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 372ee16386bb ("rxrpc: Fix races between skb free, ACK generation and replying")

Applied, thanks.

David

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] [net] rxrpc: fix uninitialized pointer dereference in debug code Arnd Bergmann <arnd@arndb.de> - 2016-08-08 12:20 +0200
  Re: [PATCH] [net] rxrpc: fix uninitialized pointer dereference in debug code David Howells <dhowells@redhat.com> - 2016-08-08 14:50 +0200

csiph-web