Re: [PATCH v4] mfd: dm355evm_msp: Refactoring for add_child()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4] mfd: dm355evm_msp: Refactoring for add_child()
Date	2016-08-08 13:40 +0200
Message-ID	<s3R4t-PQ-1@gated-at.bofh.it> (permalink)
References	<rQaA2-13g-9@gated-at.bofh.it> <s2IcV-4Ek-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>> v4: Further feedback was integrated into this message.
> 
> This is not a good change-log.  What actually changed?

Which kind of information would you find more useful in this case?


>> @@ -222,19 +222,20 @@ static struct device *add_child(struct i2c_client *client, const char *name,
>>  		status = platform_device_add_resources(pdev, &r, 1);
>>  		if (status < 0) {
>>  			dev_dbg(&pdev->dev, "can't add irq\n");
>> -			goto err;
>> +			goto put_device;
>>  		}
>>  	}
>>  
>>  	status = platform_device_add(pdev);
>> +	if (status)
>> +		goto put_device;
>>  
>> -err:
>> -	if (status < 0) {
>> -		platform_device_put(pdev);
>> -		dev_err(&client->dev, "can't add %s dev\n", name);
>> -		return ERR_PTR(status);
>> -	}
>>  	return &pdev->dev;
>> +
>> +put_device:
>> +	platform_device_put(pdev);
>> +	dev_err(&client->dev, "failed to add device %s\n", name);
> 
> ... and remove this line.

Do you really want that this error message should be deleted?

How does this response fit to your request to introduce such a message
for the function "add_numbered_child" (on 2016-06-08)?
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1162299.html
https://lkml.org/lkml/2016/6/8/467

Regards,
Markus

Thread

Re: [PATCH v4] mfd: dm355evm_msp: Refactoring for add_child() Lee Jones <lee.jones@linaro.org> - 2016-08-05 10:00 +0200
  Re: [PATCH v4] mfd: dm355evm_msp: Refactoring for add_child() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-08 13:40 +0200
    Re: [PATCH v4] mfd: dm355evm_msp: Refactoring for add_child() Lee Jones <lee.jones@linaro.org> - 2016-08-09 11:30 +0200
      Re: [PATCH v4] mfd: dm355evm_msp: Refactoring for add_child() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-09 12:00 +0200
        Re: [PATCH v4] mfd: dm355evm_msp: Refactoring for add_child() Lee Jones <lee.jones@linaro.org> - 2016-08-09 17:40 +0200

csiph-web