Re: [PATCH 0111/1285] Replace numeric parameter like 0444 with macro

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0111/1285] Replace numeric parameter like 0444 with macro
Date	2016-08-08 13:20 +0200
Message-ID	<s3QL8-Ev-49@gated-at.bofh.it> (permalink)
References	<s1G3w-3Jf-37@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Tue, Aug 02, 2016 at 06:41:29PM +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
> 
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>

I choose to ignore this and other similar patches you have submitted
for the TPM driver subsystem.

/Jarkko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0111/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 13:30 +0200
  Re: [PATCH 0111/1285] Replace numeric parameter like 0444 with macro Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-08-08 13:20 +0200

csiph-web