Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1457715

Re: [RFC PATCH 1/3] net: Remove unnecessary memset in __snmp6_fill_stats64

Show all headers | View raw

Jia He <hejianet@gmail.com> wrote:
> buff[] will be assigned later, so memset is not necessary.
> 
> Signed-off-by: Jia He <hejianet@gmail.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
> Cc: James Morris <jmorris@namei.org>
> Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
> Cc: Patrick McHardy <kaber@trash.net>
> ---
>  net/ipv6/addrconf.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index ab3e796..43fa8d0 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -4967,7 +4967,6 @@ static inline void __snmp6_fill_stats64(u64 *stats, void __percpu *mib,
>  
>  	BUG_ON(pad < 0);
>  
> -	memset(buff, 0, sizeof(buff));
>  	buff[0] = IPSTATS_MIB_MAX;
>  
>  	for_each_possible_cpu(c) {
                for (i = 1; i < IPSTATS_MIB_MAX; i++)
                        buff[i] += snmp_get_cpu_field64(mib, c, i, syncpoff);

Without memset result of buff[i] += ... is undefined.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/3] net: Improve snmp6_fill_stats Jia He <hejianet@gmail.com> - 2016-08-08 12:30 +0200
  [RFC PATCH 1/3] net: Remove unnecessary memset in __snmp6_fill_stats64 Jia He <hejianet@gmail.com> - 2016-08-08 12:30 +0200
    Re: [RFC PATCH 1/3] net: Remove unnecessary memset in  __snmp6_fill_stats64 Florian Westphal <fw@strlen.de> - 2016-08-08 13:20 +0200
      Re: [RFC PATCH 1/3] net: Remove unnecessary memset in  __snmp6_fill_stats64 hejianet <hejianet@gmail.com> - 2016-08-08 15:10 +0200
    Re: [RFC PATCH 1/3] net: Remove unnecessary memset in  __snmp6_fill_stats64 Eric Dumazet <eric.dumazet@gmail.com> - 2016-08-09 12:20 +0200
  [RFC PATCH 2/3] net: Replace for_each_possible_cpu with for_each_online_cpu Jia He <hejianet@gmail.com> - 2016-08-08 12:30 +0200
    Re: [RFC PATCH 2/3] net: Replace for_each_possible_cpu with  for_each_online_cpu David Miller <davem@davemloft.net> - 2016-08-08 20:00 +0200
    Re: [RFC PATCH 2/3] net: Replace for_each_possible_cpu with  for_each_online_cpu Eric Dumazet <eric.dumazet@gmail.com> - 2016-08-09 12:20 +0200
  [RFC PATCH 3/3] net: Remove the useless parameter of __snmp6_fill_statsdev Jia He <hejianet@gmail.com> - 2016-08-08 12:30 +0200

csiph-web