Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1457666

Re: [Intel-gfx] include/drm/i915_drm.h:96: possible bad bitmask ?

Show all headers | View raw

On Mon, Aug 08, 2016 at 10:31:32AM +0100, David Binderman wrote:
> Hello there,
> 
> Recent versions of gcc say this:
> 
> include/drm/i915_drm.h:96:34: warning: result of ‘65535 << 20’
> requires 37 bits to represent, but ‘int’ only has 32 bits
> [-Wshift-overflow=]
> 
> Source code is
> 
> #define   INTEL_BSM_MASK (0xFFFF << 20)
> 
> Maybe something like
> 
> #define   INTEL_BSM_MASK (0xFFFFUL<< 20)
> 
> might be better.

Yup. Care to bake this into a patch (with s-o-b and everything per
Documentation/SubmittingPatches) so I can apply it?
-Daniel

> 
> 
> Regards
> 
> David Binderman
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

include/drm/i915_drm.h:96: possible bad bitmask ? David Binderman <linuxdev.baldrick@gmail.com> - 2016-08-08 11:40 +0200
  Re: [Intel-gfx] include/drm/i915_drm.h:96: possible bad bitmask ? Daniel Vetter <daniel@ffwll.ch> - 2016-08-08 11:50 +0200
    Re: [Intel-gfx] include/drm/i915_drm.h:96: possible bad bitmask ? Dave Airlie <airlied@gmail.com> - 2016-08-09 05:00 +0200
      Re: [Intel-gfx] include/drm/i915_drm.h:96: possible bad bitmask ? Dave Gordon <david.s.gordon@intel.com> - 2016-08-09 18:10 +0200

csiph-web