RE: [Intel-wired-lan] [PATCH net-next v3 1/2] e1000e: factor out systim sanitization

From	"Brown, Aaron F" <aaron.f.brown@intel.com>
Newsgroups	linux.kernel
Subject	RE: [Intel-wired-lan] [PATCH net-next v3 1/2] e1000e: factor out systim sanitization
Date	2016-08-04 21:40 +0200
Message-ID	<s2wEN-5rB-11@gated-at.bofh.it> (permalink)
References	<rY8hH-53q-3@gated-at.bofh.it> <rZfh8-5uR-23@gated-at.bofh.it> <rZfh8-5uR-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.org] On
> Behalf Of Jarod Wilson
> Sent: Tuesday, July 26, 2016 11:26 AM
> To: linux-kernel@vger.kernel.org
> Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH net-next v3 1/2] e1000e: factor out systim
> sanitization
> 
> This is prepatory work for an expanding list of adapter families that have
> occasional ~10 hour clock jumps when being used for PTP. Factor out the
> sanitization function and convert to using a feature (bug) flag, per
> suggestion from Jesse Brandeburg.
> 
> Littering functional code with device-specific checks is much messier than
> simply checking a flag, and having device-specific init set flags as needed.
> There are probably a number of other cases in the e1000e code that
> could/should be converted similarly.
> 
> Suggested-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> CC: Jesse Brandeburg <jesse.brandeburg@intel.com>
> CC: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> CC: intel-wired-lan@lists.osuosl.org
> CC: netdev@vger.kernel.org
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
> ---
>  drivers/net/ethernet/intel/e1000e/82571.c  |  6 ++-
>  drivers/net/ethernet/intel/e1000e/e1000.h  |  1 +
>  drivers/net/ethernet/intel/e1000e/netdev.c | 66 ++++++++++++++++++-------
> -----
>  3 files changed, 44 insertions(+), 29 deletions(-)

Tested-by: Aaron Brown <aaron.f.brown@intel.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next v3 1/2] e1000e: factor out systim sanitization Jarod Wilson <jarod@redhat.com> - 2016-07-26 20:30 +0200
  RE: [Intel-wired-lan] [PATCH net-next v3 1/2] e1000e: factor out  systim sanitization "Avargil, Raanan" <raanan.avargil@intel.com> - 2016-07-27 16:10 +0200
    Re: [Intel-wired-lan] [PATCH net-next v3 1/2] e1000e: factor out  systim sanitization Jarod Wilson <jarod@redhat.com> - 2016-07-27 17:10 +0200
      Re: [Intel-wired-lan] [PATCH net-next v3 1/2] e1000e: factor out  systim sanitization Jarod Wilson <jarod@redhat.com> - 2016-08-02 03:40 +0200
        RE: [Intel-wired-lan] [PATCH net-next v3 1/2] e1000e: factor out  systim sanitization "Brown, Aaron F" <aaron.f.brown@intel.com> - 2016-08-02 12:30 +0200
    RE: [Intel-wired-lan] [PATCH net-next v3 1/2] e1000e: factor out  systim sanitization "Woodford, Timothy W." <Timothy.Woodford@jhuapl.edu> - 2016-07-27 23:30 +0200
      RE: [Intel-wired-lan] [PATCH net-next v3 1/2] e1000e: factor out  systim sanitization "Woodford, Timothy W." <Timothy.Woodford@jhuapl.edu> - 2016-07-29 16:50 +0200
        RE: [Intel-wired-lan] [PATCH net-next v3 1/2] e1000e: factor out  systim sanitization "Brown, Aaron F" <aaron.f.brown@intel.com> - 2016-08-04 21:40 +0200
  RE: [Intel-wired-lan] [PATCH net-next v3 1/2] e1000e: factor out  systim sanitization "Brown, Aaron F" <aaron.f.brown@intel.com> - 2016-08-04 21:40 +0200

csiph-web