Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1456501
| From | Christoph Hellwig <hch@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 37/45] drivers: use req op accessor |
| Date | 2016-08-04 17:50 +0200 |
| Message-ID | <s2t4d-2PF-11@gated-at.bofh.it> (permalink) |
| References | <rGM3T-2uj-3@gated-at.bofh.it> <rGM3U-2uj-11@gated-at.bofh.it> <s2cZr-dY-23@gated-at.bofh.it> <s2e5c-U8-19@gated-at.bofh.it> <s2f1g-1tP-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Aug 03, 2016 at 07:30:29PM -0500, Shaun Tancheff wrote: > I think the translation in loop.c is suspicious here: > > "if use DIO && not (a flush_flag or discard_flag)" > should translate to: > "if use DIO && not ((a flush_flag) || op == discard)" > > But in the patch I read: > "if use DIO && ((not a flush_flag) || op == discard) > > Which would have DIO && discards follow the AIO path? Indeed. Sorry for missing out on your patch, I just sent a fix in reply to Dave's other report earlier which is pretty similar to yours.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 37/45] drivers: use req op accessor Ross Zwisler <zwisler@gmail.com> - 2016-08-04 00:40 +0200
Re: [PATCH 37/45] drivers: use req op accessor Mike Christie <mchristi@redhat.com> - 2016-08-04 01:50 +0200
Re: [PATCH 37/45] drivers: use req op accessor Shaun Tancheff <shaun.tancheff@seagate.com> - 2016-08-04 02:50 +0200
Re: [PATCH 37/45] drivers: use req op accessor Mike Christie <mchristi@redhat.com> - 2016-08-04 07:50 +0200
Re: [PATCH 37/45] drivers: use req op accessor Christoph Hellwig <hch@infradead.org> - 2016-08-04 17:50 +0200
Re: [PATCH 37/45] drivers: use req op accessor Shaun Tancheff <shaun.tancheff@seagate.com> - 2016-08-04 18:40 +0200
csiph-web