Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1456474
| From | Luiz Capitulino <lcapitulino@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/2] x86/x2apic: check return value on probe |
| Date | 2016-08-04 17:10 +0200 |
| Message-ID | <s2srw-2sp-35@gated-at.bofh.it> (permalink) |
| References | <s2srv-2sp-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
cpuhp_setup_state() can fail. If it does, we have to
return 0 to upper layers.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
arch/x86/kernel/apic/x2apic_cluster.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/apic/x2apic_cluster.c b/arch/x86/kernel/apic/x2apic_cluster.c
index 18b1704..eb4e459 100644
--- a/arch/x86/kernel/apic/x2apic_cluster.c
+++ b/arch/x86/kernel/apic/x2apic_cluster.c
@@ -187,12 +187,14 @@ int x2apic_dead_cpu(unsigned int this_cpu)
static int x2apic_cluster_probe(void)
{
+ int ret;
+
if (!x2apic_mode)
return 0;
- cpuhp_setup_state(CPUHP_X2APIC_PREPARE, "X2APIC_PREPARE",
+ ret = cpuhp_setup_state(CPUHP_X2APIC_PREPARE, "X2APIC_PREPARE",
x2apic_prepare_cpu, x2apic_dead_cpu);
- return 1;
+ return ret < 0 ? 0 : 1;
}
static const struct cpumask *x2apic_cluster_target_cpus(void)
--
2.5.5
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] x86/x2apic: fix conversion to CPU hotplug state machine Luiz Capitulino <lcapitulino@redhat.com> - 2016-08-04 17:10 +0200
[PATCH 1/2] x86/x2apic: fix NULL pointer def during boot Luiz Capitulino <lcapitulino@redhat.com> - 2016-08-04 17:10 +0200
Re: [PATCH 1/2] x86/x2apic: fix NULL pointer def during boot Davidlohr Bueso <dave@stgolabs.net> - 2016-08-04 20:50 +0200
[PATCH 1/2] x86/x2apic: fix NULL pointer def during boot Igor Mammedov <imammedo@redhat.com> - 2016-08-10 21:30 +0200
[PATCH 1/2] x86/x2apic: fix NULL pointer def during boot Igor Mammedov <imammedo@redhat.com> - 2016-08-10 23:20 +0200
[PATCH 2/2] x86/x2apic: check return value on probe Luiz Capitulino <lcapitulino@redhat.com> - 2016-08-04 17:10 +0200
Re: [PATCH 0/2] x86/x2apic: fix conversion to CPU hotplug state machine Luiz Capitulino <lcapitulino@redhat.com> - 2016-08-09 15:30 +0200
csiph-web