Re: [PATCH] Input: sis-i2c: select CONFIG_CRC_ITU_T

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Input: sis-i2c: select CONFIG_CRC_ITU_T
Date	2016-08-04 17:30 +0200
Message-ID	<s2sKR-2Gk-11@gated-at.bofh.it> (permalink)
References	<s2qJ4-1aK-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 04, 2016 at 03:07:06PM +0200, Arnd Bergmann wrote:
> The newly added sis_i2c driver fails to link without the CRC_ITU_T
> driver enabled:
> 
> drivers/input/touchscreen/sis_i2c.o: In function `sis_ts_irq_handler':
> sis_i2c.c:(.text+0xc0): undefined reference to `crc_itu_t'
> 
> This adds a Kconfig select statement.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: a485cb037fe6 ("Input: add driver for SiS 9200 family I2C touchscreen controllers")

Thank you Arnd.

> ---
>  drivers/input/touchscreen/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index 8d893cefb0e3..2fb1f430a431 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -1074,6 +1074,7 @@ config TOUCHSCREEN_SILEAD
>  config TOUCHSCREEN_SIS_I2C
>  	tristate "SiS 9200 family I2C touchscreen"
>  	depends on I2C
> +	select CRC_ITU_T
>  	depends on GPIOLIB || COMPILE_TEST
>  	help
>  	  This enables support for SiS 9200 family over I2C based touchscreens.
> -- 
> 2.9.0
> 

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Input: sis-i2c: select CONFIG_CRC_ITU_T Arnd Bergmann <arnd@arndb.de> - 2016-08-04 15:20 +0200
  Re: [PATCH] Input: sis-i2c: select CONFIG_CRC_ITU_T Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-08-04 17:30 +0200

csiph-web