Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1456410

Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

Show all headers | View raw

Hi Russell,


On 04-08-2016 11:47, Russell King - ARM Linux wrote:
> On Thu, Aug 04, 2016 at 11:44:51AM +0100, Jose Abreu wrote:
>> When running HDMI compliance tests we noticed that sometimes
>> the edid changes but the get_modes() function is not called
>> so the edid is not updated. Moving the edid reading to the
>> detect() callback ensures that the edid is correctly updated
>> after an hotplug.
> Wouldn't this be a bug in the higher levels of DRM?
>

I am not sure if this is a bug in DRM or a bad implementation of
dw-hdmi. I've seen at least two more drivers that do the edid
reading at the .detect() callback: nouveau and gma500. This is
noticeable if while sending video the edid changes like in a
compliance environment. In the environment that I tested I was
sending video and swapped an edid that had support for AI packets
to another one without support and I noticed that although the
hotplug is generated the edid was not being updated.

Best regards,
Jose Miguel Abreu

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2016-08-04 12:50 +0200
  Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to  .detect() callback Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-08-04 12:50 +0200
    Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to  .detect() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2016-08-04 16:00 +0200
      Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to  .detect() callback Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-08-04 16:40 +0200
        Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to  .detect() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2016-08-04 17:00 +0200
          Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to  .detect() callback Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-08-04 17:10 +0200
            Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to  .detect() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2016-08-04 19:20 +0200
              Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to  .detect() callback Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-08-05 01:20 +0200
                Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to  .detect() callback Daniel Vetter <daniel@ffwll.ch> - 2016-08-05 10:10 +0200
                Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to  .detect() callback Chris Wilson <chris@chris-wilson.co.uk> - 2016-08-05 10:20 +0200
                Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to  .detect() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2016-08-08 18:30 +0200
                Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to  .detect() callback Daniel Vetter <daniel@ffwll.ch> - 2016-08-09 08:10 +0200

csiph-web