Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1456393
| From | Vinod Koul <vinod.koul@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/7] k3dma: Fix hisi burst clipping |
| Date | 2016-08-04 15:10 +0200 |
| Message-ID | <s2qzn-166-17@gated-at.bofh.it> (permalink) |
| References | <rXdjr-25c-3@gated-at.bofh.it> <rXdjs-25c-11@gated-at.bofh.it> <rYlRD-516-5@gated-at.bofh.it> <s0oLo-2v7-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jul 29, 2016 at 03:40:46PM -0700, John Stultz wrote: > On Sun, Jul 24, 2016 at 12:25 AM, Vinod Koul <vinod.koul@intel.com> wrote: > > On Wed, Jul 20, 2016 at 08:53:03PM -0700, John Stultz wrote: > >> From: Andy Green <andy.green@linaro.org> > >> > >> Max burst len is a 4-bit field, but at the moment it's clipped with > >> a 5-bit constant... reduce it to that which can be expressed > > > > Maybe we should GENMASK() etc to avoid these errors.. > > Not sure I follow what you're thinking here... can you clarify a bit? I am assuming the 4bit field was a mistake by orignal author. Using GENMASK, BIT etc macro helps you to avoid those as one would look at datasheet and say this is specfied as bit 5 thru 9, so let me say GENMASK(5, 0) rather than a typo which missed 5th bit. But ofcourse if the error was due to some other reason then this one doesnt help. -- ~Vinod
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 1/7] k3dma: Fix hisi burst clipping John Stultz <john.stultz@linaro.org> - 2016-07-30 00:50 +0200
Re: [PATCH 1/7] k3dma: Fix hisi burst clipping Vinod Koul <vinod.koul@intel.com> - 2016-08-04 15:10 +0200
Re: [PATCH 1/7] k3dma: Fix hisi burst clipping John Stultz <john.stultz@linaro.org> - 2016-08-04 19:40 +0200
Re: [PATCH 1/7] k3dma: Fix hisi burst clipping Vinod Koul <vinod.koul@intel.com> - 2016-08-05 05:30 +0200
csiph-web