Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1456373

Re: [PATCH/RFC] mm, oom: Fix uninitialized ret in task_will_free_mem()

Show all headers | View raw

On 2016/08/04 5:19, Geert Uytterhoeven wrote:
>     mm/oom_kill.c: In function ‘task_will_free_mem’:
>     mm/oom_kill.c:767: warning: ‘ret’ may be used uninitialized in this function
> 
> If __task_will_free_mem() is never called inside the for_each_process()
> loop, ret will not be initialized.

Recently we are likely overlook this warning because newer versions (!?) do
not warn it. We need to try to compile using newer and older versions.

> 
> Fixes: 1af8bb43269563e4 ("mm, oom: fortify task_will_free_mem()")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Untested. I'm not familiar with the code, hence the default value of
> true was deducted from the logic in the loop (return false as soon as
> __task_will_free_mem() has returned false).

I think ret = true is correct. Andrew, please send to linux.git.

> ---
>  mm/oom_kill.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index 7d0a275df822e9e1..d53a9aa00977cbd0 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -764,7 +764,7 @@ bool task_will_free_mem(struct task_struct *task)
>  {
>  	struct mm_struct *mm = task->mm;
>  	struct task_struct *p;
> -	bool ret;
> +	bool ret = true;
>  
>  	/*
>  	 * Skip tasks without mm because it might have passed its exit_mm and
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH/RFC] mm, oom: Fix uninitialized ret in task_will_free_mem() Geert Uytterhoeven <geert@linux-m68k.org> - 2016-08-03 22:30 +0200
  Re: [PATCH/RFC] mm, oom: Fix uninitialized ret in  task_will_free_mem() Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-08-04 14:30 +0200
    Re: [PATCH/RFC] mm, oom: Fix uninitialized ret in  task_will_free_mem() Andrew Morton <akpm@linux-foundation.org> - 2016-08-04 23:50 +0200
      Re: [PATCH/RFC] mm, oom: Fix uninitialized ret in task_will_free_mem() Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-08-08 14:10 +0200

csiph-web