[PATCH 1/2] f2fs: allow copying file range only in between regular files

From	Chao Yu <yuchao0@huawei.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/2] f2fs: allow copying file range only in between regular files
Date	2016-08-04 14:20 +0200
Message-ID	<s2pMZ-qc-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Only if two input files are regular files, we allow copying data in
range of them, otherwise, deny it.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
 fs/f2fs/file.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index be81722..409f0ec 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -2162,8 +2162,8 @@ static int f2fs_move_file_range(struct file *file_in, loff_t pos_in,
 	if (unlikely(f2fs_readonly(src->i_sb)))
 		return -EROFS;
 
-	if (S_ISDIR(src->i_mode) || S_ISDIR(dst->i_mode))
-		return -EISDIR;
+	if (!S_ISREG(src->i_mode) || !S_ISREG(dst->i_mode))
+		return -EINVAL;
 
 	if (f2fs_encrypted_inode(src) || f2fs_encrypted_inode(dst))
 		return -EOPNOTSUPP;
-- 
2.8.2.311.gee88674

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 1/2] f2fs: allow copying file range only in between regular files Chao Yu <yuchao0@huawei.com> - 2016-08-04 14:20 +0200

csiph-web