Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1456280
| From | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RESEND][PATCH v2 2/2] powerpc/fadump: parse fadump reserve memory size based on memory range |
| Date | 2016-08-04 11:50 +0200 |
| Message-ID | <s2nrQ-76H-17@gated-at.bofh.it> (permalink) |
| References | <s2abg-6TC-9@gated-at.bofh.it> <s2abg-6TC-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hari Bathini <hbathini@linux.vnet.ibm.com> writes:
...
> /**
> * fadump_calculate_reserve_size(): reserve variable boot area 5% of System RAM
> *
> @@ -212,12 +262,17 @@ static inline unsigned long fadump_calculate_reserve_size(void)
> {
> unsigned long size;
>
> + /* sets fw_dump.reserve_bootvar */
> + parse_fadump_reserve_mem();
> +
> /*
> * Check if the size is specified through fadump_reserve_mem= cmdline
> * option. If yes, then use that.
> */
> if (fw_dump.reserve_bootvar)
> return fw_dump.reserve_bootvar;
> + else
> + printk(KERN_INFO "fadump: calculating default boot size\n");
>
> /* divide by 20 to get 5% of value */
> size = memblock_end_of_DRAM() / 20;
The code already knows how to reserve 5% based on the size of the machine's
memory, as long as no commandline parameter is passed. So why can't we
just use that logic?
cheers
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RESEND][PATCH v2 2/2] powerpc/fadump: parse fadump reserve memory size based on memory range Hari Bathini <hbathini@linux.vnet.ibm.com> - 2016-08-03 21:40 +0200
Re: [RESEND][PATCH v2 2/2] powerpc/fadump: parse fadump reserve memory size based on memory range Michael Ellerman <mpe@ellerman.id.au> - 2016-08-04 11:50 +0200
Re: [RESEND][PATCH v2 2/2] powerpc/fadump: parse fadump reserve memory size based on memory range Hari Bathini <hbathini@linux.vnet.ibm.com> - 2016-08-04 21:00 +0200
Re: [RESEND][PATCH v2 2/2] powerpc/fadump: parse fadump reserve memory size based on memory range Hari Bathini <hbathini@linux.vnet.ibm.com> - 2016-08-08 10:20 +0200
Re: [RESEND][PATCH v2 2/2] powerpc/fadump: parse fadump reserve memory size based on memory range Michael Ellerman <mpe@ellerman.id.au> - 2016-08-08 11:00 +0200
Re: [RESEND][PATCH v2 2/2] powerpc/fadump: parse fadump reserve memory size based on memory range Hari Bathini <hbathini@linux.vnet.ibm.com> - 2016-08-08 11:30 +0200
csiph-web