Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1456245

[tip:perf/urgent] perf tools: Fix build failure on perl script context

Show all headers | View raw

Commit-ID:  b581c01fff646b5075d65359c8667de9c667da9e
Gitweb:     http://git.kernel.org/tip/b581c01fff646b5075d65359c8667de9c667da9e
Author:     Namhyung Kim <namhyung@kernel.org>
AuthorDate: Tue, 2 Aug 2016 11:43:17 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 2 Aug 2016 12:11:06 -0300

perf tools: Fix build failure on perl script context

On my Archlinux machine, perf faild to build like below:

    CC       scripts/perl/Perf-Trace-Util/Context.o
  In file included from /usr/lib/perl5/core/perl/CORE/perl.h:3905:0,
                   from Context.xs:23:
  /usr/lib/perl5/core/perl/CORE/inline.h: In function :
  /usr/lib/perl5/core/perl/CORE/cop.h:612:13: warning: declaration of 'av'
                                  shadows a previous local [-Werror-shadow]
             AV *av =3D GvAV(PL_defgv);
                 ^
  /usr/lib/perl5/core/perl/CORE/inline.h:526:5: note: in expansion of
                                  macro 'CX_POP_SAVEARRAY'
         CX_POP_SAVEARRAY(cx);
         ^~~~~~~~~~~~~~~~
  In file included from /usr/lib/perl5/core/perl/CORE/perl.h:5853:0,
                   from Context.xs:23:
  /usr/lib/perl5/core/perl/CORE/inline.h:518:9: note:
                                  shadowed declaration is here
         AV *av;
             ^~

What I did to fix is adding '-Wno-shadow' as the error message said it's
the cause of the failure.  Since it's from the perl (not perf) code
base, we don't have the control so I just wanted to ignore the warning
when compiling perl scripting code.

Committer note:

This also fixes the build on Fedora Rawhide.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20160802024317.31725-1-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/scripts/perl/Perf-Trace-Util/Build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/perf/scripts/perl/Perf-Trace-Util/Build b/tools/perf/scripts/perl/Perf-Trace-Util/Build
index 928e110..34faecf 100644
--- a/tools/perf/scripts/perl/Perf-Trace-Util/Build
+++ b/tools/perf/scripts/perl/Perf-Trace-Util/Build
@@ -1,3 +1,5 @@
 libperf-y += Context.o
 
-CFLAGS_Context.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-nested-externs -Wno-undef -Wno-switch-default
+CFLAGS_Context.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes
+CFLAGS_Context.o += -Wno-unused-parameter -Wno-nested-externs -Wno-undef
+CFLAGS_Context.o += -Wno-switch-default -Wno-shadow

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] perf tools: Fix build failture on perl script context Namhyung Kim <namhyung@kernel.org> - 2016-08-02 04:50 +0200
  Re: [PATCH] perf tools: Fix build failture on perl script context Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-08-02 15:30 +0200
  Re: [PATCH] perf tools: Fix build failture on perl script context Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-08-02 15:50 +0200
    Re: [PATCH] perf tools: Fix build failture on perl script context Namhyung Kim <namhyung@kernel.org> - 2016-08-02 16:10 +0200
      Re: [PATCH] perf tools: Fix build failture on perl script context Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-08-02 16:30 +0200
        Re: [PATCH] perf tools: Fix build failture on perl script context Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-08-02 17:20 +0200
  [tip:perf/urgent] perf tools: Fix build failure on perl script  context tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-08-04 11:20 +0200

csiph-web