Re: [RFC][PATCH 3/4] power: reset: Add sram-reboot-mode driver

From	Bjorn Andersson <bjorn.andersson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH 3/4] power: reset: Add sram-reboot-mode driver
Date	2016-08-04 07:40 +0200
Message-ID	<s2jxT-4Ea-5@gated-at.bofh.it> (permalink)
References	<s2dst-EM-7@gated-at.bofh.it> <s2dst-EM-5@gated-at.bofh.it> <s2fkB-1Rq-7@gated-at.bofh.it> <s2hcK-3aD-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed 03 Aug 20:08 PDT 2016, John Stultz wrote:

> On Wed, Aug 3, 2016 at 6:03 PM, Bjorn Andersson
> <bjorn.andersson@linaro.org> wrote:
> > On Wed 03 Aug 16:05 PDT 2016, John Stultz wrote:
> >
> > [..]
> >> diff --git a/drivers/power/reset/sram-reboot-mode.c b/drivers/power/reset/sram-reboot-mode.c
[..]
> >> +     ret = reboot_mode_register(&sram_rbm->reboot);
> >
> > I think you should take the time to throw in a
> > devm_reboot_mode_register(), it would save you from the
> > dev_set_drvdata() and you can drop the remove function.
> 
> So I've only got a vague sense of what your suggesting here. Do you
> have a pointer to a good example?
> 

https://patchwork.kernel.org/patch/9262691/
https://patchwork.kernel.org/patch/9262693/

Regards,
Bjorn

Thread

[RFC][PATCH 3/4] power: reset: Add sram-reboot-mode driver John Stultz <john.stultz@linaro.org> - 2016-08-04 01:10 +0200
  Re: [RFC][PATCH 3/4] power: reset: Add sram-reboot-mode driver Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-04 03:10 +0200
    Re: [RFC][PATCH 3/4] power: reset: Add sram-reboot-mode driver John Stultz <john.stultz@linaro.org> - 2016-08-04 05:10 +0200
      Re: [RFC][PATCH 3/4] power: reset: Add sram-reboot-mode driver Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-04 07:40 +0200
  Re: [RFC][PATCH 3/4] power: reset: Add sram-reboot-mode driver Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-08-07 01:50 +0200

csiph-web