Re: [PATCH] UHS-SD card for Hisilicon Hikey

From	Jaehoon Chung <jh80.chung@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] UHS-SD card for Hisilicon Hikey
Date	2016-08-04 03:20 +0200
Message-ID	<s2fuh-1UY-3@gated-at.bofh.it> (permalink)
References	<s2fuh-1UY-5@gated-at.bofh.it> <s21B0-1hs-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 08/03/2016 07:22 PM, Jin Guojun wrote:
> mmc: dw_mmc-k3: Hisilicon Hikey have no tuning function in dw_mmc-k3.c,so we must do the tuning function stub when we init UHS card.

Refer to Shawn's previous comment.
"No, please amend the commit title line as "mmc: dw_mmc: xxxxx"
And add "linux-mmc@vger.kernel.org", patch version, Changelog, etc..

Best Regards,
Jaehoon Chung

> 
> Signed-off-by: Jin Guojun <kid.jin@hisilicon.com>
> ---
>  drivers/mmc/host/dw_mmc-k3.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c
> index 8e9d886..6247894 100644
> --- a/drivers/mmc/host/dw_mmc-k3.c
> +++ b/drivers/mmc/host/dw_mmc-k3.c
> @@ -131,11 +131,17 @@ static void dw_mci_hi6220_set_ios(struct dw_mci *host, struct mmc_ios *ios)
>  	host->bus_hz = clk_get_rate(host->biu_clk);
>  }
>  
> +static int dw_mci_hi6220_execute_tuning(struct dw_mci_slot *slot, u32 opcode)
> +{
> +	return 0;
> +}
> +
>  static const struct dw_mci_drv_data hi6220_data = {
>  	.caps			= dw_mci_hi6220_caps,
>  	.switch_voltage		= dw_mci_hi6220_switch_voltage,
>  	.set_ios		= dw_mci_hi6220_set_ios,
>  	.parse_dt		= dw_mci_hi6220_parse_dt,
> +	.execute_tuning		= dw_mci_hi6220_execute_tuning,
>  };
>  
>  static const struct of_device_id dw_mci_k3_match[] = {
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] UHS-SD card for Hisilicon Hikey Jin Guojun <kid.jin@hisilicon.com> - 2016-08-03 12:30 +0200
  Re: [PATCH] UHS-SD card for Hisilicon Hikey Jaehoon Chung <jh80.chung@samsung.com> - 2016-08-04 03:20 +0200

csiph-web