Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1457265
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Pavel Machek <pavel@ucw.cz> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] Fix sysrq emergency thaw |
| Date | Fri, 05 Aug 2016 22:20:01 +0200 |
| Message-ID | <s2TL3-3TQ-1@gated-at.bofh.it> (permalink) |
| References | <rX8Wu-7Sc-9@gated-at.bofh.it> |
| X-Original-To | Charles Gong <cggong@fb.com> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.23 (2014-03-12) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 23 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Alexander Viro <viro@zeniv.linux.org.uk>, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Christoph Hellwig <hch@lst.de> |
| X-Original-Date | Fri, 5 Aug 2016 22:14:47 +0200 |
| X-Original-Message-ID | <20160805201447.GC7999@amd> |
| X-Original-References | <5823da614460b8c40809e6e0a6de172a9c4f4611.1468965479.git.cggong@fb.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1457265 |
Show key headers only | View raw
On Wed 2016-07-20 16:11:16, Charles Gong wrote:
> "SYSRQ + J" triggers a call to emergency_thaw_all(). Currently, this
> is an infinite loop. Once we trigger it, we'll need to do a hard
> power-cycle. There are users reporting this bug from 2012 to 2016, for
> example, at https://bugzilla.kernel.org/show_bug.cgi?id=47741.
>
> This happens because thaw_bdev() fails to return -EINVAL in the
> non-frozen case, so fix it so that do_one_thaw() can recognize this case
> and quit from looping. I checked that none of the other thaw_bdev()
> callers check the return value.
>
> The regression was introduced in commit 4504230a7156 ("freeze_bdev: grab
> active reference to frozen superblocks").
>
> Reviewed-by: Chris Mason <clm@fb.com>
> Signed-off-by: Charles Gong <cggong@fb.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
(even magic should be finite...)
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH] Fix sysrq emergency thaw Pavel Machek <pavel@ucw.cz> - 2016-08-05 22:20 +0200
csiph-web