Re: [PATCH resend] clocksource: Defer override invalidation unless clock is unstable

From	Kyle Walker <kwalker@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH resend] clocksource: Defer override invalidation unless clock is unstable
Date	2016-08-05 20:40 +0200
Message-ID	<s2Sch-2Ir-1@gated-at.bofh.it> (permalink)
References	<rZi5j-7eZ-17@gated-at.bofh.it> <rZieZ-7i5-13@gated-at.bofh.it> <rZy0u-y1-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Good evening John,

On Wed, Jul 27, 2016 at 10:29 AM, Kyle Walker <kwalker@redhat.com> wrote:
> The issue I'm running into is that the override is not HRT compatible yet.
> Though it will be later in the boot process, unless the clocksource watchdog
> marks the clocksource as unstable.
>
> The issue with the current implementation is that the override_name value is
> disabled when the tsc is first checked, before the watchdog has a chance to
> check it and mark it stable or unstable.
>
> Without patch:
> $ dmesg | grep -e clocksource
> <snip>
> clocksource: refined-jiffies: <snip>
> Kernel command line: <snip> clocksource=tsc
> clocksource: hpet: <snip>
> clocksource: xen: <snip>
> clocksource: jiffies: <snip>
> clocksource: Switched to clocksource xen
> clocksource: acpi_pm: <snip>
> tsc: Refined TSC clocksource calibration: 2394.399 MHz
>
> clocksource: tsc: <snip>
> clocksource: Override clocksource tsc is not HRT compatible - <snip>
>
>
> With patch:
> $ dmesg | grep -e clocksource
> <snip>
> clocksource: refined-jiffies:<snip>
> Kernel command line: <snip> clocksource=tsc
> clocksource: hpet: <snip>
> clocksource: xen: <snip>
>
> clocksource: jiffies: <snip>
> clocksource: Switched to clocksource xen
> clocksource: acpi_pm: <snip>
> tsc: Refined TSC clocksource calibration: 2394.461 MHz
> clocksource: tsc: <snip>
> clocksource: Override clocksource tsc is not currently HRT compatible
> - deferring
> clocksource: Switched to clocksource tsc
>

Is there anything else needed from my end? Please let me know if there is
any further information or clarification I can provide.

Have a great evening!
-- 
Kyle Walker

Thread

[PATCH resend] clocksource: Defer override invalidation unless clock is unstable Kyle Walker <kwalker@redhat.com> - 2016-07-26 23:30 +0200
  Re: [PATCH resend] clocksource: Defer override invalidation unless  clock is unstable John Stultz <john.stultz@linaro.org> - 2016-07-26 23:40 +0200
    Re: [PATCH resend] clocksource: Defer override invalidation unless  clock is unstable Kyle Walker <kwalker@redhat.com> - 2016-07-27 16:30 +0200
      Re: [PATCH resend] clocksource: Defer override invalidation unless  clock is unstable Kyle Walker <kwalker@redhat.com> - 2016-08-05 20:40 +0200
    Re: [PATCH resend] clocksource: Defer override invalidation unless  clock is unstable John Stultz <john.stultz@linaro.org> - 2016-08-05 21:10 +0200

csiph-web