Re: [PATCH v2] mm/slab: Improve performance of gathering slabinfo stats

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Christoph Lameter <cl@linux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] mm/slab: Improve performance of gathering slabinfo stats
Date	Fri, 05 Aug 2016 16:30:01 +0200
Message-ID	<s2Oil-eE-9@gated-at.bofh.it> (permalink)
References	<s2wbL-5cb-3@gated-at.bofh.it> <s2BuN-mO-23@gated-at.bofh.it>
X-Original-To	Joonsoo Kim <js1304@gmail.com>
X-X-Sender	cl@east.gentwo.org
Content-Type	text/plain; charset=US-ASCII
X-Cmae-Envelope	MS4wfAoShlfvZ8Wwh+IvM21j/uP/TkOq4yipnWhpYD8QIMydOvOvfFIHnHbVC83QSRJfABgcNtSMJ8z4j79DTnqb6kfJDRmBIRslXOeggkO+O07IcgFHuyTz IW7jDCwu6AlxlNRNNIjszqh7/O2HbLL4+4y9VHOXgsLlkCqABAIyj3ZLj6/CwWgVUoqmZqbddg6OqJBDGreBem/RO/r4eJk20J8eaxNjp48boFEGsMFIULqj bZqriKVqvKRDHQUpGaqxvV6+3Vrkt9eMWhupkT5cDqdIw8BNdhfZOb4nO8Rm0rZmwiZpHcg+oij4/MSMputjZAHGsatR6oVDr1CKYsC5vQ4+U/75ikJe+eYJ 0T+qrumGq6c3n55lYXwMqawmVrYSJSxHFl2DK+w3dk9vymqqhgHtWCsiWTmcQbmVzXnIXKg4oijHpeIHSaGY9KOmR36DLg==
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	9
Organization	linux.* mail to news gateway
X-Original-Cc	Aruna Ramakrishna <aruna.ramakrishna@oracle.com>, Linux Memory Management List <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>, Mike Kravetz <mike.kravetz@oracle.com>, Pekka Enberg <penberg@kernel.org>, David Rientjes <rientjes@google.com>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Andrew Morton <akpm@linux-foundation.org>
X-Original-Date	Fri, 5 Aug 2016 09:21:56 -0500 (CDT)
X-Original-Message-ID	<alpine.DEB.2.20.1608050919410.27772@east.gentwo.org>
X-Original-References	<1470337273-6700-1-git-send-email-aruna.ramakrishna@oracle.com> <CAAmzW4On7FWc37fQJOsDQOEOVXqK3ue+uiB0ZOFM9R5e-Jj3WQ@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1457125

Show key headers only | View raw

On Fri, 5 Aug 2016, Joonsoo Kim wrote:

> If above my comments are fixed, all counting would be done with
> holding a lock. So, atomic definition isn't needed for the SLAB.

Ditto for slub. struct kmem_cache_node is alrady defined in mm/slab.h.
Thus it is a common definition already and can be used by both.

Making nr_slabs and total_objects unsigned long would be great.

Thread

[PATCH v2] mm/slab: Improve performance of gathering slabinfo stats Aruna Ramakrishna <aruna.ramakrishna@oracle.com> - 2016-08-04 21:10 +0200
  Re: [PATCH v2] mm/slab: Improve performance of gathering slabinfo  stats Andrew Morton <akpm@linux-foundation.org> - 2016-08-04 23:10 +0200
    Re: [PATCH v2] mm/slab: Improve performance of gathering slabinfo  stats Aruna Ramakrishna <aruna.ramakrishna@oracle.com> - 2016-08-04 23:50 +0200
  Re: [PATCH v2] mm/slab: Improve performance of gathering slabinfo stats Joonsoo Kim <js1304@gmail.com> - 2016-08-05 02:50 +0200
    Re: [PATCH v2] mm/slab: Improve performance of gathering slabinfo  stats Christoph Lameter <cl@linux.com> - 2016-08-05 16:30 +0200
  Re: [PATCH v2] mm/slab: Improve performance of gathering slabinfo  stats Christoph Lameter <cl@linux.com> - 2016-08-05 16:20 +0200

csiph-web