Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1457126

Re: [PATCH 1/1] generic spidev devices must be registered

Path csiph.com!goblin1!goblin2!goblin.stu.neva.ru!gothmog.csi.it!bofh.it!news.nic.it!robomod
From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/1] generic spidev devices must be registered
Date Fri, 05 Aug 2016 16:30:01 +0200
Message-ID <s2Oil-eE-1@gated-at.bofh.it> (permalink)
References <s2NcB-80H-5@gated-at.bofh.it> <s2NFE-8dj-29@gated-at.bofh.it>
MIME-Version 1.0
Content-Type multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sT0SRK93LqpGW452"
Content-Disposition inline
X-Cookie Don't hit the keys so hard, it hurts.
User-Agent Mutt/1.6.0 (2016-04-01)
X-Sa-Exim-Connect-IP 2a01:348:6:8808:fab::3
X-Sa-Exim-Mail-From broonie@sirena.org.uk
X-Sa-Exim-Version 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-Sa-Exim-Scanned No (on mezzanine.sirena.org.uk); Unknown failure
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 40
Organization linux.* mail to news gateway
X-Original-Cc Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>, Rob Herring <robh+dt@kernel.org>, "open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, open list <linux-kernel@vger.kernel.org>
X-Original-Date Fri, 5 Aug 2016 15:21:08 +0100
X-Original-Message-ID <20160805142108.GZ10383@sirena.org.uk>
X-Original-References <1470402714-10798-1-git-send-email-fabien.lahoudere@collabora.co.uk> <20160805134342.GD25152@leverpostej>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1457126

Show key headers only | View raw


[Multipart message — attachments visible in raw view] - view raw

On Fri, Aug 05, 2016 at 02:43:43PM +0100, Mark Rutland wrote:
> On Fri, Aug 05, 2016 at 03:11:53PM +0200, Fabien Lahoudere wrote:
> > Adding spidev in the compatible list, let configure spidev from device tree
> > instead of C source code.

> I'm not keen on this.

> It ties the hardware description to today's use-case, and leaves the DT
> without information regarding the particuarl device. The binding is also
> written in terms of the userspace interface, which is backwards.

> So NAK to this as-is.

Indeed.  Fabien, please see the *extensive* and repeated previous
discussions of this topic.  Device tree is there to describe the
hardware, not the software you currently happen to be using on your
system.  Please also see the comments in the driver which explain why we
require a compatible string which is descriptive of the hardware.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 1/1] generic spidev devices must be registered Fabien Lahoudere <fabien.lahoudere@collabora.co.uk> - 2016-08-05 15:20 +0200
  Re: [PATCH 1/1] generic spidev devices must be registered Mark Rutland <mark.rutland@arm.com> - 2016-08-05 15:50 +0200
    Re: [PATCH 1/1] generic spidev devices must be registered Mark Brown <broonie@kernel.org> - 2016-08-05 16:30 +0200

csiph-web