Re: [PATCH v4] sched/deadline: remove useless param from setup_new_dl_entity

From	Juri Lelli <juri.lelli@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4] sched/deadline: remove useless param from setup_new_dl_entity
Date	2016-08-05 12:20 +0200
Message-ID	<s2Kop-69A-3@gated-at.bofh.it> (permalink)
References	(3 earlier) <rWgW5-6NT-9@gated-at.bofh.it> <rXn97-89-9@gated-at.bofh.it> <rXniO-cH-31@gated-at.bofh.it> <rXnst-gG-9@gated-at.bofh.it> <rXyQW-88M-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 22/07/16 10:58, Xunlei Pang wrote:
> On 2016/07/21 at 22:46, Juri Lelli wrote:
[...]
> > @@ -1734,9 +1724,11 @@ static void switched_to_dl(struct rq *rq, struct task_struct *p)
> >  	if (task_on_rq_queued(p)) {
> >  		/*
> >  		 * If p is not queued we will update its parameters at next
> > -		 * wakeup.
> > +		 * wakeup. If p is dl_boosted we already updated its params in
> > +		 * rt_mutex_setprio()->enqueue_task(..., ENQUEUE_REPLENISH).
> >  		 */
> > -		if (dl_time_before(p->dl.deadline, rq_clock(rq)))
> > +		if (dl_time_before(p->dl.deadline, rq_clock(rq)) &&
> > +				!p->dl.dl_boosted)
> 
> Hi Juri,
> 
> It looks good to me, only one question:
> For on_rq boosted to deadline, p->dl.deadline has been updated after rq_lock(rq) by
> rt_mutex_setprio()->enqueue_task(..., ENQUEUE_REPLENISH) and no rq clock update
> afterwards, so dl_time_before() will be false, seems p->dl.dl_boosted check is needless.
> 

Right. I removed it and posted v5. Please have a look.

Best,

- Juri

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v4] sched/deadline: remove useless param from  setup_new_dl_entity Juri Lelli <juri.lelli@arm.com> - 2016-08-05 12:20 +0200

csiph-web