Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1456980
| From | Daniel Wagner <wagi@monom.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 4/4] misc: tifm: use complete() instead of complete_all() |
| Date | 2016-08-05 11:30 +0200 |
| Message-ID | <s2JC2-5By-11@gated-at.bofh.it> (permalink) |
| References | <s2JC2-5By-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
There is only one waiter for the completion, therefore there
is no need to use complete_all(). Let's make that clear by
using complete() instead of complete_all().
The usage pattern of the completion is:
waiter context waker context
tifm_7xx1_resume()
DECLARE_COMPLETION_ONSTACK(finish_resume)
fm->finish_me = finish_resume
/* enable irq */
wait_for_completion_timeout(finish_resume)
tifm_7xx1_isr()
complete(fm->finish_me)
Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
---
drivers/misc/tifm_7xx1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/tifm_7xx1.c b/drivers/misc/tifm_7xx1.c
index a37a42f..77af41c 100644
--- a/drivers/misc/tifm_7xx1.c
+++ b/drivers/misc/tifm_7xx1.c
@@ -69,7 +69,7 @@ static irqreturn_t tifm_7xx1_isr(int irq, void *dev_id)
writel(irq_status, fm->addr + FM_INTERRUPT_STATUS);
if (fm->finish_me)
- complete_all(fm->finish_me);
+ complete(fm->finish_me);
else if (!fm->socket_change_set)
writel(TIFM_IRQ_ENABLE, fm->addr + FM_SET_INTERRUPT_ENABLE);
else
--
2.7.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] Use complete() instead of complete_all() Daniel Wagner <wagi@monom.org> - 2016-08-05 11:30 +0200 [PATCH 2/4] misc: mic: vop: use complete() instead of complete_all() Daniel Wagner <wagi@monom.org> - 2016-08-05 11:30 +0200 [PATCH 4/4] misc: tifm: use complete() instead of complete_all() Daniel Wagner <wagi@monom.org> - 2016-08-05 11:30 +0200 [PATCH 1/4] misc: mic: scif: use complete() instead of complete_all() Daniel Wagner <wagi@monom.org> - 2016-08-05 11:30 +0200 [PATCH 3/4] misc: ti-st: use complete() instead of complete_all() Daniel Wagner <wagi@monom.org> - 2016-08-05 11:30 +0200
csiph-web