Re: [RFC PATCH 1/2] net: macb: Correct CAPS mask

Path	csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod
From	Harini Katakam <harinikatakamlinux@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 1/2] net: macb: Correct CAPS mask
Date	Fri, 05 Aug 2016 06:20:02 +0200
Message-ID	<s2EM2-2By-5@gated-at.bofh.it> (permalink)
References	<s2rvs-1NC-23@gated-at.bofh.it> <s2rvs-1NC-21@gated-at.bofh.it>
X-Original-To	Nicolas Ferre <nicolas.ferre@atmel.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pr6/3KCrdlorgcRucusrmGnn5Ojs5MIsvSgB5D57YJM=; b=glvDMPSZU0obkNjuq76aS0FDcEr62vPHnVDw2Zspfp1VZJbERV8ifbAFgFCq/5mT3O SvyTk521nqNbz+CCjChPr6P7h64KiVxuCd8fM/FLGSHCXOxvLm96c7khAS7aBh34eCpT P8fiWXrotiX1A89/LF9wHLNkt+TGAUIgwmdXfp5xDmdvEM6bm6XCKbn+WhCy2F5kbFR0 FJ3RDlGziGjg3r0IpluthcuFKp/jQkl0ZpyRCFkXBzF+Ft9V5MtA7foUHqq5LfDprWtt IMR8W8FaUI7wS/WXohy8OVQQd7dbITmlTr9qOFK0TrneKKInDsbxBdZKkiWHhCFUW8xD s17Q==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pr6/3KCrdlorgcRucusrmGnn5Ojs5MIsvSgB5D57YJM=; b=kRR82JgdF4Ie8PwFetHtUqkCwR7NPXC6M2h/rnQ7kzyXBU/8IItHpcuAUF36ZoKfT0 YSyxnRD0OkJQ2lPTSJEkvjBHFVosvBXXvOmOWo62IF5AhcsXYiHZuMiPKBGkxwc+j8it OVm67lKlGzbiJpQ5L+Q2r+5433ZzqO8hsRAje2OqInrAww/8JZ06S95tH/heVLI27d5e ovjE5RjOw1JUArBMzb3dI85BwNlCqTx1ANVxDLz+mDdg03ERqBxicC3nst1aAtpLs5YQ o2wmg7nJI1xej4yO5QYeRiQNTRTb467izZd52nciSqU9AqO12x5VnOTIdwJJGM6fusBu utFg==
X-Gm-Message-State	AEkoouu5Jz9IA1FXCoofk02TQazk9esy/gliD5u85G/T5w39jUOKnPvRBfLHK7es7wDsfBEc06oQT1B1gkfDFQ==
X-Received	by 10.25.38.207 with SMTP id m198mr25592028lfm.201.1470370694857; Thu, 04 Aug 2016 21:18:14 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Content-Transfer-Encoding	8BIT
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	51
Organization	linux.* mail to news gateway
X-Original-Cc	Harini Katakam <harini.katakam@xilinx.com>, davem@davemloft.net, netdev@vger.kernel.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Punnaiah Choudary Kalluri <punnaia@xilinx.com>, "michals@xilinx.com" <michals@xilinx.com>, Neil Armstrong <narmstrong@baylibre.com>
X-Original-Date	Fri, 5 Aug 2016 09:48:14 +0530
X-Original-Message-ID	<CAFcVEC+s3d9Lpz54PBygDXC-1s75WJcPxGxb8202gEuaerJDGw@mail.gmail.com>
X-Original-References	<1470036023-22368-1-git-send-email-harinik@xilinx.com> <f4a7d36f-2686-f8ae-35aa-ca5902cc9197@atmel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1456871

Show key headers only | View raw

On Thu, Aug 4, 2016 at 7:37 PM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> Le 01/08/2016 à 09:20, Harini Katakam a écrit :
>> USRIO and JUMBO CAPS have the same mask.
>> Fix the same.
>>
>> Signed-off-by: Harini Katakam <harinik@xilinx.com>
>
> Hi,
> Indeed there's a bug...
>
>
>> ---
>>  drivers/net/ethernet/cadence/macb.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
>> index 36893d8..b6fcf10 100644
>> --- a/drivers/net/ethernet/cadence/macb.h
>> +++ b/drivers/net/ethernet/cadence/macb.h
>> @@ -403,11 +403,11 @@
>>  #define MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII  0x00000004
>>  #define MACB_CAPS_NO_GIGABIT_HALF            0x00000008
>>  #define MACB_CAPS_USRIO_DISABLED             0x00000010
>> +#define MACB_CAPS_JUMBO                              0x00000020
>>  #define MACB_CAPS_FIFO_MODE                  0x10000000
>>  #define MACB_CAPS_GIGABIT_MODE_AVAILABLE     0x20000000
>>  #define MACB_CAPS_SG_DISABLED                        0x40000000
>>  #define MACB_CAPS_MACB_IS_GEM                        0x80000000
>> -#define MACB_CAPS_JUMBO                              0x00000010
>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
> Can you please send it independently without the RFC tag in the subject
> and with the following tags in the body as well:
>
> Fixes: ce721a702197 ("net: ethernet: cadence-macb: Add disabled usrio caps")
> Cc: stable@vger.kernel.org # v4.5+
>

Thanks Nicolas. I'll do that.

Regards,
Harini

>>  /* Bit manipulation macros */
>>  #define MACB_BIT(name)                                       \
>>
>
> Thanks, bye,
> --
> Nicolas Ferre

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH 1/2] net: macb: Correct CAPS mask Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-08-04 16:10 +0200
  Re: [RFC PATCH 1/2] net: macb: Correct CAPS mask Harini Katakam <harinikatakamlinux@gmail.com> - 2016-08-05 06:20 +0200

csiph-web