Re: [RFC V2 PATCH 00/25] Kernel NET policy

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Alexei Starovoitov <alexei.starovoitov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC V2 PATCH 00/25] Kernel NET policy
Date	Fri, 05 Aug 2016 03:40:01 +0200
Message-ID	<s2Chb-TM-1@gated-at.bofh.it> (permalink)
References	<s2wlr-5gw-3@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KnW2ZyQnfjLNBSAOHRLqhIN9PdtcU6EQblXgWFf03rM=; b=AZb/lwmdlwJN5r70JGvvwFKeqhxwR6tsXQls70eyj+LFy0lgkRU41AG8uxOVkVvtpZ hTUhrpW5OGMOM9rcpgzhHyCyMLk+hVuelyh03ZqC/S+HuizEMSC6rrhzZkanfnBMpAHc L9LNQR25N644G42KtO/UOTQcGXallxzXcJRYpMmYSuzHQmj+kW62uJQXGMNpGKVnnwru j+oudeTXBQEe6KluSMxRcgZRvMMdzFimKUe/A+mfhD3818MEf0aRh3mCLpU1qzDYVkpZ ER1fsbv+3dDbpht7zxxNdQ+rBeViDg4Fhne6ClBZDbHY7Yqx2L9uwxw9p2MvpL5gBdB3 7QBA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KnW2ZyQnfjLNBSAOHRLqhIN9PdtcU6EQblXgWFf03rM=; b=bUm/25Ajc+lQHZaV4zlcjSgm0dyC23uw8iSFzMQhxt376taRecjMD90Wjbl7gPu/ae UTNyjDuHP5DxQDlnbm0QSSOluSpTiG1QBlcaW4N8kHZAszQNivTmZ3GLRvRtSraZGwpe 6Kai7m4tQp77ehqb2V3epq2sVKiyKxAHiNdS5zzyJSLQjgfKltULf/bRY64BdDMktV97 7VPt44QWJ0VFO92DQ4ORyE+H/HtwKzrb+PLn7ZBmVrijTnXZrj7PBfPQhsnyJ2g2JU0+ e+I+IpQjdTnC9kRwHuzWhDKT6V2m/lt7EYLL88pOA2l1d3iGdhfJ1I9mqdtytdQgh3nH jCzg==
X-Gm-Message-State	AEkoouvytfN/OWtKkmW+KKum8vzkPREDhccwbRUFKGWrI9KbqUx+O75/iG7BYFqJZdWWLA==
X-Received	by 10.66.248.10 with SMTP id yi10mr121773625pac.31.1470360706319; Thu, 04 Aug 2016 18:31:46 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	27
Organization	linux.* mail to news gateway
X-Original-Cc	davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jeffrey.t.kirsher@intel.com, mingo@redhat.com, peterz@infradead.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, akpm@linux-foundation.org, keescook@chromium.org, viro@zeniv.linux.org.uk, gorcunov@openvz.org, john.stultz@linaro.org, aduyck@mirantis.com, ben@decadent.org.uk, decot@googlers.com, fw@strlen.de, alexander.duyck@gmail.com, daniel@iogearbox.net, tom@herbertland.com, rdunlap@infradead.org, xiyou.wangcong@gmail.com, hannes@stressinduktion.org, jesse.brandeburg@intel.com, andi@firstfloor.org
X-Original-Date	Thu, 4 Aug 2016 18:31:40 -0700
X-Original-Message-ID	<20160805013138.GA52225@ast-mbp.thefacebook.com>
X-Original-References	<1420076354-4861-1-git-send-email-kan.liang@intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1456842

Show key headers only | View raw

On Wed, Dec 31, 2014 at 08:38:49PM -0500, kan.liang@intel.com wrote:
> 
> Changes since V1:
>  - Using work queue to set Rx network flow classification rules and search
>    available NET policy object asynchronously.
>  - Using RCU lock to replace read-write lock
>  - Redo performance test and update performance results.
>  - Some minor modification for codes and documents.
>  - Remove i40e related patches which will be submitted in separate thread.

Most of the issues brought up in the prior submission were not addressed,
so one more NACK from me as well.
My objection with this approach is the same as others:
such policy doesn't belong in the kernel.

>  1. Why userspace tool cannot do the same thing?
>     A: Kernel is more suitable for NET policy.
>        - User space code would be far more complicated to get right and perform
>          well . It always need to work with out of date state compared to the
>          latest, because it cannot do any locking with the kernel state.
>        - User space code is less efficient than kernel code, because of the
>          additional context switches needed.
>        - Kernel is in the right position to coordinate requests from multiple
>          users.

and above excuses is the reason to hack flow director rules in the kernel?
You can do the same in user space. It's not a kernel job.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC V2 PATCH 00/25] Kernel NET policy kan.liang@intel.com - 2016-08-04 21:30 +0200
  [RFC V2 PATCH 02/25] net/netpolicy: init NET policy kan.liang@intel.com - 2016-08-04 21:30 +0200
  [RFC V2 PATCH 11/25] net/netpolicy: add MIX policy kan.liang@intel.com - 2016-08-04 21:30 +0200
  [RFC V2 PATCH 01/25] net: introduce NET policy kan.liang@intel.com - 2016-08-04 21:30 +0200
  Re: [RFC V2 PATCH 00/25] Kernel NET policy Stephen Hemminger <stephen@networkplumber.org> - 2016-08-05 02:10 +0200
    RE: [RFC V2 PATCH 00/25] Kernel NET policy "Liang, Kan" <kan.liang@intel.com> - 2016-08-05 15:50 +0200
  Re: [RFC V2 PATCH 00/25] Kernel NET policy Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-08-05 03:40 +0200

csiph-web