Re: [PATCH] shmem: Fix link error if huge pages support is disabled

From	"Kirill A. Shutemov" <kirill@shutemov.name>
Newsgroups	linux.kernel
Subject	Re: [PATCH] shmem: Fix link error if huge pages support is disabled
Date	2016-08-03 21:10 +0200
Message-ID	<s29Ie-6D8-27@gated-at.bofh.it> (permalink)
References	<s28Ct-5J5-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 03, 2016 at 07:58:19PM +0200, Geert Uytterhoeven wrote:
> If CONFIG_TRANSPARENT_HUGE_PAGECACHE=n, HPAGE_PMD_NR evaluates to
> BUILD_BUG_ON(), and may cause (e.g. with gcc 4.12):
> 
>     mm/built-in.o: In function `shmem_alloc_hugepage':
>     shmem.c:(.text+0x17570): undefined reference to `__compiletime_assert_1365'
> 
> To fix this, move the assignment to hindex after the check for huge
> pages support.
> 
> Fixes: 800d8c63b2e989c2 ("shmem: add huge pages support")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
 Kirill A. Shutemov

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] shmem: Fix link error if huge pages support is disabled Geert Uytterhoeven <geert@linux-m68k.org> - 2016-08-03 20:00 +0200
  Re: [PATCH] shmem: Fix link error if huge pages support is disabled "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-08-03 21:10 +0200

csiph-web