Re: [PATCH 1/2] thunderbolt: Fix resume quirk for Falcon Ridge 4C.

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Lukas Wunner <lukas@wunner.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] thunderbolt: Fix resume quirk for Falcon Ridge 4C.
Date	Wed, 03 Aug 2016 10:50:01 +0200
Message-ID	<s202d-eJ-5@gated-at.bofh.it> (permalink)
References	<rZdIl-4pd-11@gated-at.bofh.it>
X-Original-To	Andreas Noever <andreas.noever@gmail.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.6.1 (2016-04-27)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	55
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, xavier.gnata@gmail.com, gregkh@linuxfoundation.org
X-Original-Date	Wed, 3 Aug 2016 10:43:54 +0200
X-Original-Message-ID	<20160803084354.GA4360@wunner.de>
X-Original-References	<20160726164038.1481-1-andreas.noever@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1455701

Show key headers only | View raw

On Tue, Jul 26, 2016 at 06:40:37PM +0200, Andreas Noever wrote:
> The quirk 'quirk_apple_wait_for_thunderbolt' did not fire on Falcon
> Ridge 4C controllers with subdevice/subvendor set to zero. This lead
> to lost pci devices on system resume.
> 
> Older thunderbolt controllers (pre Falcon Ridge) used the same device id
> for bridges and for the controller. On Apple hardware the subvendor- &
> subdevice-ids were set for the controller, but not for bridges. So that
> is what was used to differentiate between the two. Starting with Falcon
> Ridge bridges and controllers received different device ids.
> Additionally on some MacBookPro models (but not all) the
> subvendor/subdevice was zeroed.
> 
> Starting with a42fb351c (thunderbolt: Allow loading of module on recent
> Apple MacBooks with thunderbolt 2 controller) the thunderbolt driver
> binds to all Falcon Ridge 4C controllers (irregardless of
> subvendor/subdevice). The corresponding quirk was not updated.
> 
> This commit changes the quirk to check the device class instead of its
> subvendor-/subdeviceids. This works for all generations of Thunderbolt
> controllers.
> 
> Signed-off-by: Andreas Noever <andreas.noever@gmail.com>

FWIW, this is
Reviewed-by: Lukas Wunner <lukas@wunner.de>

I also tested it successfully on Light Ridge. I'm sending a follow-up
patch separately so that Falcon Ridge chips are no longer declared
unsupported.

Thanks,

Lukas

> ---
>  drivers/pci/quirks.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index ee72ebe..75b2105 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -3326,8 +3326,7 @@ static void quirk_apple_wait_for_thunderbolt(struct pci_dev *dev)
>  		    || (nhi->device != PCI_DEVICE_ID_INTEL_LIGHT_RIDGE &&
>  			nhi->device != PCI_DEVICE_ID_INTEL_CACTUS_RIDGE_4C &&
>  			nhi->device != PCI_DEVICE_ID_INTEL_FALCON_RIDGE_4C_NHI)
> -		    || nhi->subsystem_vendor != 0x2222
> -		    || nhi->subsystem_device != 0x1111)
> +		    || nhi->class != PCI_CLASS_SYSTEM_OTHER << 8)
>  		goto out;
>  	dev_info(&dev->dev, "quirk: waiting for thunderbolt to reestablish PCI tunnels...\n");
>  	device_pm_wait_for_dev(&dev->dev, &nhi->dev);
> -- 
> 2.9.0

Thread

[PATCH 1/2] thunderbolt: Fix resume quirk for Falcon Ridge 4C. Andreas Noever <andreas.noever@gmail.com> - 2016-07-26 18:50 +0200
  Re: [PATCH 1/2] thunderbolt: Fix resume quirk for Falcon Ridge 4C. Lukas Wunner <lukas@wunner.de> - 2016-08-03 10:50 +0200
  [PATCH] thunderbolt: Don't declare Falcon Ridge unsupported Lukas Wunner <lukas@wunner.de> - 2016-08-03 10:50 +0200
    Re: [PATCH] thunderbolt: Don't declare Falcon Ridge unsupported Andreas Noever <andreas.noever@gmail.com> - 2016-08-08 09:30 +0200

csiph-web