Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1453345
| From | Johannes Weiner <hannes@cmpxchg.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] memcg: put soft limit reclaim out of way if the excess tree is empty |
| Date | 2016-08-01 19:20 +0200 |
| Message-ID | <s1p2G-MQ-31@gated-at.bofh.it> (permalink) |
| References | <s1ikx-4Uz-1@gated-at.bofh.it> <s1met-7pd-23@gated-at.bofh.it> <s1met-7pd-21@gated-at.bofh.it> <s1n0S-7W5-19@gated-at.bofh.it> <s1ntT-88a-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Aug 01, 2016 at 05:24:54PM +0200, Michal Hocko wrote:
> @@ -2564,7 +2559,13 @@ unsigned long mem_cgroup_soft_limit_reclaim(pg_data_t *pgdat, int order,
> return 0;
>
> mctz = soft_limit_tree_node(pgdat->node_id);
> - if (soft_limit_tree_empty(mctz))
> +
> + /*
> + * Do not even bother to check the largest node if the node
root
> + * is empty. Do it lockless to prevent lock bouncing. Races
> + * are acceptable as soft limit is best effort anyway.
> + */
> + if (RB_EMPTY_ROOT(&mctz->rb_root))
> return 0;
Other than that, looks good. Please retain my
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
in version 2.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] memcg: put soft limit reclaim out of way if the excess tree is empty Michal Hocko <mhocko@kernel.org> - 2016-08-01 12:10 +0200
Re: [PATCH] memcg: put soft limit reclaim out of way if the excess tree is empty Michal Hocko <mhocko@kernel.org> - 2016-08-01 16:20 +0200
Re: [PATCH] memcg: put soft limit reclaim out of way if the excess tree is empty Johannes Weiner <hannes@cmpxchg.org> - 2016-08-01 17:10 +0200
Re: [PATCH] memcg: put soft limit reclaim out of way if the excess tree is empty Michal Hocko <mhocko@kernel.org> - 2016-08-01 17:40 +0200
Re: [PATCH] memcg: put soft limit reclaim out of way if the excess tree is empty Johannes Weiner <hannes@cmpxchg.org> - 2016-08-01 19:20 +0200
Re: [PATCH] memcg: put soft limit reclaim out of way if the excess tree is empty Michal Hocko <mhocko@kernel.org> - 2016-08-01 19:50 +0200
Re: [PATCH] memcg: put soft limit reclaim out of way if the excess tree is empty Vladimir Davydov <vdavydov@virtuozzo.com> - 2016-08-01 16:40 +0200
csiph-web