Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1453294

Re: [PATCH] net: thunderx: correct bound check in nic_config_loopback

From "Levin, Alexander" <alexander.levin@verizon.com>
Newsgroups linux.kernel
Subject Re: [PATCH] net: thunderx: correct bound check in nic_config_loopback
Date 2016-08-01 18:10 +0200
Message-ID <s1nWV-8b-1@gated-at.bofh.it> (permalink)
References <s0P8R-2Ce-1@gated-at.bofh.it> <s1266-2zl-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 07/31/2016 12:41 PM, Sunil Kovvuri wrote:
> Thanks for finding.
> A much better fix would be,
> 
> -       if (lbk->vf_id > MAX_LMAC)
> +       if (lbk->vf_id >= nic->num_vf_en)
>                 return -1;
> 
> where 'num_vf_en' reflects the exact number of physical interfaces or
> LMACs on the system.

Right. I see quite a few more places that compare to MAX_LMAC vs
num_vf_en. What was the reasoning behind it then?


Thanks,
Sasha

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: thunderx: correct bound check in nic_config_loopback "Levin, Alexander" <alexander.levin@verizon.com> - 2016-07-31 05:00 +0200
  Re: [PATCH] net: thunderx: correct bound check in nic_config_loopback Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-07-31 12:00 +0200
  Re: [PATCH] net: thunderx: correct bound check in nic_config_loopback Sunil Kovvuri <sunil.kovvuri@gmail.com> - 2016-07-31 18:50 +0200
    Re: [PATCH] net: thunderx: correct bound check in  nic_config_loopback "Levin, Alexander" <alexander.levin@verizon.com> - 2016-08-01 18:10 +0200
      Re: [PATCH] net: thunderx: correct bound check in nic_config_loopback Sunil Kovvuri <sunil.kovvuri@gmail.com> - 2016-08-02 13:50 +0200

csiph-web