Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1453268

Re: [PATCH] silence warning in drivers/ata/libata-scsi.c when building W=1

Show all headers | View raw

On Sun, Jul 31, 2016 at 11:28:34PM -0400, Valdis Kletnieks wrote:
> When building with W=1, we get these warnings:
> 
> drivers/ata/libata-scsi.c: In function 'ata_mselect_caching':
> drivers/ata/libata-scsi.c:3637:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
>     if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
>                        ~~~~~^~~~~~~~~
> drivers/ata/libata-scsi.c: In function 'ata_mselect_control':
> drivers/ata/libata-scsi.c:3702:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
>     if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
>                        ~~~~~^~~~~~~~~
> 
> So give them the extra () and make things a bit clearer for both the
> compiler and programmer...
> 
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>

The offending commit got already reverted.

Thanks!

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] silence warning in drivers/ata/libata-scsi.c when building W=1 Valdis Kletnieks <Valdis.Kletnieks@vt.edu> - 2016-08-01 05:50 +0200
  Re: [PATCH] silence warning in drivers/ata/libata-scsi.c when  building W=1 Tejun Heo <tj@kernel.org> - 2016-08-01 17:10 +0200

csiph-web