Re: [PATCH 1/4] mac80211: mesh: flush stations before beacons are stopped

From	Johannes Berg <johannes@sipsolutions.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4] mac80211: mesh: flush stations before beacons are stopped
Date	2016-08-01 12:20 +0200
Message-ID	<s1iud-500-7@gated-at.bofh.it> (permalink)
References	(2 earlier) <rPhWV-1co-17@gated-at.bofh.it> <rPhWV-1co-15@gated-at.bofh.it> <rUpqN-1JD-1@gated-at.bofh.it> <s1iud-500-9@gated-at.bofh.it> <rUpqN-1JD-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2016-07-13 at 10:11 +0000, Machani, Yaniv wrote:
> On Wed, Jun 29, 2016 at 10:14:19, Johannes Berg wrote:
> > Cc: Hahn, Maital
> > Subject: Re: [PATCH 1/4] mac80211: mesh: flush stations before
> > beacons 
> > are stopped
> > 
> > On Tue, 2016-06-28 at 14:13 +0300, Yaniv Machani wrote:
> > > From: Maital Hahn <maitalm@ti.com>
> > > 
> > > Some drivers (e.g. wl18xx) expect that the last stage in the 
> > > de-initialization process will be stopping the beacons, similar
> > > to ap.
> > > Update ieee80211_stop_mesh() flow accordingly.
> > > 
> > How well have you tested that with other drivers?
> > 
> 
> Sorry for the delayed response (I've been out) and thanks for your
> comments,
> I have tested it with RT3572 as well, and didn't see any issue.
> I'll update the comment to reflect that.
> 

I'm actually reasonably sure that it *must* work, similiar to the AP
mode change, since it's always valid to remove stations while the the
mesh beacon is still active.

I hoped you'd actually figure out that line of reasoning and put it
into the commit message :)

johannes

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/4] mac80211: mesh: flush stations before beacons are  stopped Johannes Berg <johannes@sipsolutions.net> - 2016-08-01 12:20 +0200

csiph-web