RE: [PATCH 1/1] mwifiex: remove superfluous condition

From	Amitkumar Karwar <akarwar@marvell.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH 1/1] mwifiex: remove superfluous condition
Date	2016-08-01 12:50 +0200
Message-ID	<s1iXg-5ai-35@gated-at.bofh.it> (permalink)
References	<s0WtH-7nW-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> From: Heinrich Schuchardt [mailto:xypron.glpk@gmx.de]
> Sent: Sunday, July 31, 2016 4:09 PM
> To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo
> Cc: linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Heinrich Schuchardt
> Subject: [PATCH 1/1] mwifiex: remove superfluous condition
> 
> for_each_property_of_node is only executed if the property prop is not
> NULL.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c
> b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c
> index 7897037..128add8 100644
> --- a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c
> +++ b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c
> @@ -1482,7 +1482,7 @@ int mwifiex_dnld_dt_cfgdata(struct mwifiex_private
> *priv,
>  			continue;
> 
>  		/* property header is 6 bytes, data must fit in cmd buffer
> */
> -		if (prop && prop->value && prop->length > 6 &&
> +		if (prop->value && prop->length > 6 &&
>  		    prop->length <= MWIFIEX_SIZE_OF_CMD_BUFFER - S_DS_GEN) {
>  			ret = mwifiex_send_cmd(priv, HostCmd_CMD_CFG_DATA,
>  					       HostCmd_ACT_GEN_SET, 0,

Thanks. The patch looks fine to me.

Acked-by: Amitkumar Karwar <akarwar@marvell.com>

Regards,
Amitkumar

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] mwifiex: remove superfluous condition Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-07-31 12:50 +0200
  RE: [PATCH 1/1] mwifiex: remove superfluous condition Amitkumar Karwar <akarwar@marvell.com> - 2016-08-01 12:50 +0200

csiph-web