Re: [PATCH] memory: omap-gpmc: Delete an unnecessary check before the function call "gpiochip_free_own_desc"

From	Roger Quadros <rogerq@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] memory: omap-gpmc: Delete an unnecessary check before the function call "gpiochip_free_own_desc"
Date	2016-08-01 11:40 +0200
Message-ID	<s1hRw-4vm-11@gated-at.bofh.it> (permalink)
References	(13 earlier) <mSsDN-4wa-61@gated-at.bofh.it> <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <rY8B4-5pp-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Markus,

On 23/07/16 20:09, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 23 Jul 2016 18:54:02 +0200
> 
> The gpiochip_free_own_desc() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/memory/omap-gpmc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> index 869c83f..e138875 100644
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -2143,9 +2143,7 @@ err_child_fail:
>  	ret = -ENODEV;
>  
>  err_cs:
> -	if (waitpin_desc)
> -		gpiochip_free_own_desc(waitpin_desc);
> -
> +	gpiochip_free_own_desc(waitpin_desc);
>  err:
>  	gpmc_cs_free(cs);
>  
> 
This looks good to me. I will queue this for v4.8. Thanks.

cheers,
-roger

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] memory: omap-gpmc: Delete an unnecessary check before the  function call "gpiochip_free_own_desc" Roger Quadros <rogerq@ti.com> - 2016-08-01 11:40 +0200

csiph-web