Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1453034

[Urgent PATCH] arm64: dts: uniphier: fix IRQ trigger type of ARMv8 timer

Show all headers | View raw

Since commit 1e2a7d78499e ("irqdomain: Don't set type when mapping
an IRQ"), the interrupt type is strictly checked.  Without this
patch, this board would not boot any more.

Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
says that the 3rd cell should be either 1 (edge) or 4 (level)
depending on the trigger type.  As the CA72 Generic Timer provides
active-low interrupts, the value of the 3rd cell should be 4.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Suggested-by: Marc Zyngier <marc.zyngier@arm.com>
---
Arnd, Olof,

I guess you are about to send pull-reqs for v4.8 cycle.
Could you include this one in them?
After IRQ updates for 4.8 were merged, my board would not
boot at all.  I consulted experts and looks like my DT
was wrong.

I could do this after -rc1 is out because it is apparently a
bug fix, but in that case the for-next branch in ASOC will be
broken for me, which would make bisect-ability difficult for me.


 arch/arm64/boot/dts/socionext/uniphier-ph1-ld20.dtsi | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/socionext/uniphier-ph1-ld20.dtsi b/arch/arm64/boot/dts/socionext/uniphier-ph1-ld20.dtsi
index fd1af50..bafbcce 100644
--- a/arch/arm64/boot/dts/socionext/uniphier-ph1-ld20.dtsi
+++ b/arch/arm64/boot/dts/socionext/uniphier-ph1-ld20.dtsi
@@ -117,10 +117,7 @@
 
 	timer {
 		compatible = "arm,armv8-timer";
-		interrupts = <1 13 0xf01>,
-			     <1 14 0xf01>,
-			     <1 11 0xf01>,
-			     <1 10 0xf01>;
+		interrupts = <1 13 4>, <1 14 4>, <1 11 4>, <1 10 4>;
 	};
 
 	soc {
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[Urgent PATCH] arm64: dts: uniphier: fix IRQ trigger type of ARMv8 timer Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-08-01 10:20 +0200
  Re: [Urgent PATCH] arm64: dts: uniphier: fix IRQ trigger type of  ARMv8 timer Marc Zyngier <marc.zyngier@arm.com> - 2016-08-01 10:30 +0200
    Re: [Urgent PATCH] arm64: dts: uniphier: fix IRQ trigger type of  ARMv8 timer Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-08-01 10:40 +0200
  Re: [Urgent PATCH] arm64: dts: uniphier: fix IRQ trigger type of ARMv8 timer Arnd Bergmann <arnd@arndb.de> - 2016-08-10 23:00 +0200

csiph-web