Re: [PATCH 1/1] net: e1000: do not use uninitalized variable.

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] net: e1000: do not use uninitalized variable.
Date	2016-08-01 05:50 +0200
Message-ID	<s1coN-Tv-5@gated-at.bofh.it> (permalink)
References	<s0VnX-6Kr-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Sun, 31 Jul 2016 11:30:58 +0200

> phy_data has to be set to zero to avoid undefined
> behavior.

In your opinion.

phy_data is only used in conditions where it has been initialized
in this function.

Therefore, please read the function carefully instead of just having
knee jerk reactions to whatever the compiler spits out.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] net: e1000: do not use uninitalized variable. Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-07-31 11:40 +0200
  Re: [PATCH 1/1] net: e1000: do not use uninitalized variable. David Miller <davem@davemloft.net> - 2016-08-01 05:50 +0200

csiph-web