Re: [PATCH v2 1/2] vfio : resume notifier

From	Zhou Jie <zhoujie2011@cn.fujitsu.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] vfio : resume notifier
Date	2016-08-01 04:20 +0200
Message-ID	<s1aZH-8uR-1@gated-at.bofh.it> (permalink)
References	<rWy6C-1fD-15@gated-at.bofh.it> <s0jC2-7Er-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi, Alex

On 2016/7/30 1:11, Alex Williamson wrote:
> On Tue, 19 Jul 2016 15:52:45 +0800
> Zhou Jie <zhoujie2011@cn.fujitsu.com> wrote:
>
>> From: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
>
> An empty commit log is unacceptable for all but the most trivial
> patches.
>
> There's also no sign-off on this patch.
Sorry. I should note it.

> I also don't know why we need this since you previously found that for
> QEMU, ordering of error versus resume notifications is not guaranteed,
> which is why I thought we went with a status flag within the struct
> vfio_device_info.  I'm not adding an interrupt to the user that has
> no users.  This was not part of the most recent discussion we had about
> this, so I'm lost why this patch exists. Thanks,
>
> Alex
I will remove the resume interrupt.

Sincerely
ZhouJie

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/2] vfio : resume notifier Alex Williamson <alex.williamson@redhat.com> - 2016-07-29 19:20 +0200
  Re: [PATCH v2 1/2] vfio : resume notifier Zhou Jie <zhoujie2011@cn.fujitsu.com> - 2016-08-01 04:20 +0200

csiph-web