Re: [PATCH 1/5] bfa: mark symbols static where possible

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] bfa: mark symbols static where possible
Date	2016-08-03 10:00 +0200
Message-ID	<s1ZfP-89Q-7@gated-at.bofh.it> (permalink)
References	<s1WhY-615-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wednesday, August 3, 2016 12:45:50 PM CEST kbuild test robot wrote:
> All errors (new ones prefixed by >>):
> 
>    drivers/scsi/bfa/bfad.c: In function 'bfad_drv_uninit':
> >> drivers/scsi/bfa/bfad.c:888:2: error: implicit declaration of function 'bfa_isr_disable' [-Werror=implicit-function-declaration]
>      bfa_isr_disable(&bfad->bfa);
>      ^
>    cc1: some warnings being treated as errors
> 

Ah right: This is called in a function that gets removed in patch 5,
after which it is actually local. I made a mistake here when I went
through a repeated search for local functions.

I'll wait for other comments first before I send a fixed version.

	Arnd

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/5] bfa: mark symbols static where possible Arnd Bergmann <arnd@arndb.de> - 2016-08-03 10:00 +0200

csiph-web