Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1455627
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] virtio: fix error handling for debug builds |
| Date | 2016-08-03 06:30 +0200 |
| Message-ID | <s1VYB-5Um-13@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
On error, virtqueue_add calls START_USE but not END_USE. Thankfully that's normally empty anyway, but might not be when debugging. Fix it up. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/virtio/virtio_ring.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 5ed228d..e383ecd 100644 --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -428,6 +428,7 @@ unmap_release: if (indirect) kfree(desc); + END_USE(vq); return -EIO; } -- MST
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] virtio: fix error handling for debug builds "Michael S. Tsirkin" <mst@redhat.com> - 2016-08-03 06:30 +0200
csiph-web