Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1455518

[PATCH v6 4/6] drm/i915/skl: Ensure pipes with changed wms get added to the state

From Lyude <cpaul@redhat.com>
Newsgroups linux.kernel
Subject [PATCH v6 4/6] drm/i915/skl: Ensure pipes with changed wms get added to the state
Date 2016-08-03 00:50 +0200
Message-ID <s1QFz-2lk-17@gated-at.bofh.it> (permalink)
References <s1QFz-2lk-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


If we're enabling a pipe, we'll need to modify the watermarks on all
active planes. Since those planes won't be added to the state on
their own, we need to add them ourselves.

Signed-off-by: Lyude <cpaul@redhat.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Cc: stable@vger.kernel.org
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 2c12b66..6f5beb3 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -4080,6 +4080,10 @@ skl_compute_ddb(struct drm_atomic_state *state)
 		ret = skl_allocate_pipe_ddb(cstate, ddb);
 		if (ret)
 			return ret;
+
+		ret = drm_atomic_add_affected_planes(state, &intel_crtc->base);
+		if (ret)
+			return ret;
 	}
 
 	return 0;
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v6 0/6] Finally fix watermarks Lyude <cpaul@redhat.com> - 2016-08-03 00:50 +0200
  [PATCH v6 5/6] drm/i915: Move CRTC updating in atomic_commit into it's own hook Lyude <cpaul@redhat.com> - 2016-08-03 00:50 +0200
  [PATCH v6 1/6] drm/i915/skl: Add support for the SAGV, fix underrun hangs Lyude <cpaul@redhat.com> - 2016-08-03 00:50 +0200
    Re: [PATCH v6 1/6] drm/i915/skl: Add support for the SAGV, fix  underrun hangs Maarten Lankhorst <maarten.lankhorst@linux.intel.com> - 2016-08-03 10:00 +0200
  [PATCH v6 4/6] drm/i915/skl: Ensure pipes with changed wms get added to the state Lyude <cpaul@redhat.com> - 2016-08-03 00:50 +0200
  [PATCH v6 2/6] drm/i915/gen9: Only copy WM results for changed pipes to skl_hw Lyude <cpaul@redhat.com> - 2016-08-03 00:50 +0200
  [PATCH v6 6/6] drm/i915/skl: Update DDB values atomically with wms/plane attrs Lyude <cpaul@redhat.com> - 2016-08-03 00:50 +0200
    Re: [PATCH v6 6/6] drm/i915/skl: Update DDB values atomically with  wms/plane attrs Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-08-03 17:10 +0200
      Re: [PATCH v6 6/6] drm/i915/skl: Update DDB values atomically with  wms/plane attrs Lyude Paul <cpaul@redhat.com> - 2016-08-03 23:40 +0200
      Re: [PATCH v6 6/6] drm/i915/skl: Update DDB values atomically with  wms/plane attrs Matt Roper <matthew.d.roper@intel.com> - 2016-08-04 00:30 +0200
        Re: [PATCH v6 6/6] drm/i915/skl: Update DDB values atomically with  wms/plane attrs Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-08-04 08:40 +0200

csiph-web