Re: [PATCH 0293/1285] Replace numeric parameter like 0444 with macro

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0293/1285] Replace numeric parameter like 0444 with macro
Date	2016-08-02 20:00 +0200
Message-ID	<s1M8W-7Lb-35@gated-at.bofh.it> (permalink)
References	<s1M8W-7Lb-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 02, 2016 at 06:57:31PM +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
> 
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
> ---
>  drivers/input/touchscreen/ili210x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/ili210x.c b/drivers/input/touchscreen/ili210x.c
> index ddf694b..a8a7089 100644
> --- a/drivers/input/touchscreen/ili210x.c
> +++ b/drivers/input/touchscreen/ili210x.c
> @@ -169,7 +169,7 @@ static ssize_t ili210x_calibrate(struct device *dev,
>  
>  	return count;
>  }
> -static DEVICE_ATTR(calibrate, 0644, NULL, ili210x_calibrate);
> +static DEVICE_ATTR(calibrate, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, NULL, ili210x_calibrate);

Here was a bug in the driver that you helpfully carried over. Since we
do not provide "show" method the permissions should be 0200 or S_IWUSR).

Thanks.

-- 
Dmitry

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 0293/1285] Replace numeric parameter like 0444 with macro Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-08-02 20:00 +0200

csiph-web