Re: [PATCH 1/3] mm: memcontrol: fix swap counter leak on swapout from offline cgroup

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] mm: memcontrol: fix swap counter leak on swapout from offline cgroup
Date	2016-08-02 16:50 +0200
Message-ID	<s1Jb5-5Jj-61@gated-at.bofh.it> (permalink)
References	<s1HiX-4uK-63@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon 01-08-16 16:26:24, Vladimir Davydov wrote:
[...]
> +static struct mem_cgroup *mem_cgroup_id_get_active(struct mem_cgroup *memcg)
> +{
> +	while (!atomic_inc_not_zero(&memcg->id.ref))
> +		memcg = parent_mem_cgroup(memcg);
> +	return memcg;
> +}

Does this actually work properly? Say we have root -> A so parent is
NULL if root (use_hierarchy == false).
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/3] mm: memcontrol: fix swap counter leak on swapout  from offline cgroup Michal Hocko <mhocko@kernel.org> - 2016-08-02 16:50 +0200

csiph-web